Re: [Django] #36848: Documentation doesn't directly mention that BadRequest is handled by handler400

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Kundan
Type: | Yadav
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Kundan Yadav):

i am sorry again i will keep all this in my mind am really sorry again
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Kundan
Type: | Yadav
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Lincoln):

Thanks Natalia for the quick reply.

To me (someone not familiar with Django internals) its not obvious what
the part about "reaches the ASGI/WSGI handler level" in `BadRequest` docs
means.

The part "results in a `HttpResponseBadRequest`." is ambiguous to me, that
could be a 400 response with no body.

The `handler400` docs say "the view that should be called if the HTTP
client has sent a request that caused an error condition and a response
with a status code of 400."

This is also ambiguous to me. For example a view that manually returns a
400 response, does NOT trigger this handler, when you could interpret it
to mean that.
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:6>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Kundan
Type: | Yadav
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Lincoln):

I am happy to provide a PR, since I am the one complaining
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:7>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Kundan
Type: | Yadav
Cleanup/optimization | Status: assigned
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Natalia Bidart):

Replying to [comment:7 Lincoln]:

> I am happy to provide a PR, since I am the one complaining

Amazing, thank you Lincoln! I'll switch ownership to you, following my
conversation with Kundan.
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:8>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------

Reporter: Lincoln | Owner: Lincoln
Type: | Status: assigned
Cleanup/optimization |

Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* owner: Kundan Yadav => Lincoln

--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:9>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Lincoln
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: dev
Severity: Normal | Resolution:
Keywords: handler400 | Triage Stage: Accepted
bad_request |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Lincoln):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:10>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Lincoln
Type: | Status: assigned
Cleanup/optimization |
Component: Documentation | Version: dev
Severity: Normal | Resolution:

Keywords: handler400 | Triage Stage: Ready for
bad_request | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Clifford Gama):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:11>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Lincoln

Type: | Status: closed

Cleanup/optimization |
Component: Documentation | Version: dev

Severity: Normal | Resolution: fixed

Keywords: handler400 | Triage Stage: Ready for
bad_request | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"4aefc9ea51cc2d78f43b1dc2aa69732e55d18a56" 4aefc9ea]:
{{{#!CommitTicketReference repository=""
revision="4aefc9ea51cc2d78f43b1dc2aa69732e55d18a56"
Fixed #36848 -- Mentioned BadRequest exception in docs/ref/views.txt.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:12>

[Django]

#36848: Documentation doesn't directly mention that BadRequest is handled by
handler400
-------------------------------------+-------------------------------------
Reporter: Lincoln | Owner: Lincoln
Type: | Status: closed
Cleanup/optimization |
Component: Documentation | Version: dev
Severity: Normal | Resolution: fixed
Keywords: handler400 | Triage Stage: Ready for
bad_request | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"5b7025317fcf817f8d2e72d871dccd437eb4db72" 5b70253]:
{{{#!CommitTicketReference repository=""
revision="5b7025317fcf817f8d2e72d871dccd437eb4db72"
[6.0.x] Fixed #36848 -- Mentioned BadRequest exception in
docs/ref/views.txt.

Backport of 4aefc9ea51cc2d78f43b1dc2aa69732e55d18a56 from main.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36848#comment:13>