[Django] #24376: UUIDField doesn't take a verbose_name positional arg
Django
----------------------------------------------+-----------------------
Reporter: yoyoma | Owner: nobody
Type: Uncategorized | Status: new
Component: Database layer (models, ORM) | Version: 1.8alpha1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
----------------------------------------------+-----------------------
Looking at
https://github.com/django/django/blob/master/django/db/models/fields/__init__.py#L2372,
{{{UUIDField}}} doesn't take a positional argument, which is inconsistent
with the behavior of other fields (the exception being relationship
fields). Since {{{UUIDField}}} will surely be used for more than just a
primary key replacement in some cases, it might be worth preserving this
consistency. If you core devs are ok with this, I'll make a patch.
Thoughts?
--
Ticket URL: <https://code.djangoproject.com/ticket/24376>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* needs_better_patch: => 0
* needs_docs: => 0
* type: Uncategorized => Cleanup/optimization
* needs_tests: => 0
* stage: Unreviewed => Accepted
Comment:
Sure!
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:1>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* keywords: => 1.8-beta
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:2>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by yoyoma):
[https://github.com/django/django/pull/4178 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:3>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by yoyoma):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:4>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by claudep):
* needs_tests: 0 => 1
Comment:
Could you please complement the existing test for verbose names:
`tests/model_fields/tests.py`, `BasicFieldTests.test_field_verbose_name`?
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:5>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: 1.8-beta | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by timgraham):
Would be nice to verify support for `DurationField` as well.
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:6>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:7>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Keywords: 1.8-beta | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Michael Angeletti <michael@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"ea3168dc6ced391d848c511a14cfcecfeac9d401"]:
{{{
#!CommitTicketReference repository=""
revision="ea3168dc6ced391d848c511a14cfcecfeac9d401"
Fixed #24376 -- added verbose_name arg to UUIDField
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:8>
Django
Reporter: yoyoma | Owner: nobody
Type: | Status: closed
Cleanup/optimization |
Component: Database layer | Version: 1.8alpha1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: 1.8-beta | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by Tim Graham <timograham@…>):
In [changeset:"1feeefe918e0f6ea6d633855549310dd149baed5"]:
{{{
#!CommitTicketReference repository=""
revision="1feeefe918e0f6ea6d633855549310dd149baed5"
[1.8.x] Fixed #24376 -- added verbose_name arg to UUIDField
Backport of ea3168dc6ced391d848c511a14cfcecfeac9d401 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/24376#comment:9>