[Django] #34995: Add link for admin's related widget is in the wrong place
Django
-------------------------------------------+------------------------
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------------+------------------------
--
Ticket URL: <https://code.djangoproject.com/ticket/34995>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tom Carrick | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* Attachment "Screenshot 2023-11-23 at 16.01.04.png" added.
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tom Carrick):
* owner: nobody => Tom Carrick
* status: new => assigned
Old description:
New description:
[[Image(https://code.djangoproject.com/attachment/ticket/34995/Screenshot%202023-11-23%20at%2016.01.04.png)]]
--
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:1>
Django
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Tom Carrick):
* has_patch: 0 => 1
Comment:
[PR https://github.com/django/django/pull/17517]
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:2>
Django
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+---------------------------------------
Changes (by Tom Carrick):
* version: 4.2 => 5.0
Comment:
Regression in
[https://github.com/django/django/commit/1699f8b52ac15f687cc39088401c2641022c71cd
1699f8b52ac15f687cc39088401c2641022c71cd].
So I think this is a release blocker for 5.0, not 4.2?
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:3>
Django
---------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
---------------------------------+---------------------------------------
Changes (by Natalia Bidart):
* ui_ux: 0 => 1
* stage: Unreviewed => Accepted
Comment:
Agreed, this is a 5.0 release blocker.
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:4>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Natalia Bidart):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:5>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Natalia Bidart):
* stage: Ready for checkin => Accepted
Comment:
Getting a selenium failure that needs debugging.
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:6>
Django
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Mariusz Felisiak):
* severity: Release blocker => Normal
Comment:
IMO we shouldn't treat this as a release blocker. "+" always had various
issues, you can play with font and screen sizes and you'll notice various
incorrect behaviors in the older versions of Django. I don't believe that
Django 5.0 made it significantly worse. Also, there is a huge risk that
the proposed patch will introduce further regressions. Let's don't
backport it.
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:7>
Django
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:7 Mariusz Felisiak]:
> IMO we shouldn't treat this as a release blocker. "+" always had various
issues, you can play with font and screen sizes and you'll notice various
incorrect behaviors in the older versions of Django. I don't believe that
Django 5.0 made it significantly worse. Also, there is a huge risk that
the proposed patch will introduce further regressions. Let's don't
backport it.
I leave the final decision to Natalia, I'm not going to die on this hill.
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:8>
Django
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
Comment (by Tom Carrick):
Personally, I don't think this needs to be in 4.2.x. However, I would like
to see it in 5.0. I promise to fix any regressions!
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:9>
Django
-------------------------------+---------------------------------------
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+---------------------------------------
Comment (by Natalia <124304+nessita@…>):
In [changeset:"af2fd368156439b79e4c1eb2278c433246771e44" af2fd36]:
{{{
#!CommitTicketReference repository=""
revision="af2fd368156439b79e4c1eb2278c433246771e44"
Refs #34995 -- Made Selenium tests more robust for admin_views and
admin_widgets suites.
Depending on screen sizes, the selenium tests that would "click" or
interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).
This branch switches those to using ActionChains, which ensures that the
click
(or other interaction) is performed only after successfully completing the
move to the relevant element.
Co-authored-by: Tom Carrick <t...@carrick.eu>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:10>
Django
Reporter: Tom Carrick | Owner: Tom
| Carrick
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Natalia Bidart):
* stage: Accepted => Ready for checkin
Comment:
I have merged the PR #17517 in `main` and will review how a potential
backport would look like in `stable/5.0x`. Then I'll report back on next
steps. Thanks everyone!
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):
I have locally backported and tested
999ba9db6d6331eaa58af77debba42754bcc1a8e in `stable/5.0.x` and I haven't
find any (new) Admin UI issues, only improvements. I have tested small
(phone), medium (tablet) and wide (desktop) screens, both horizontal and
vertical rotated viewports, light and dark modes, and LTR and RTL
languages.
I'm a bit dizzy at this point but I'm fairly confident that with this
change, the "green plus sign" is consistently shown to the right of the
M2M selector (in LTR langs, it's shown to the left in RTL langs) and I
think this is an improvement over what's currently available.
Given the above, and given Tom's explicit commitment to fix any potential
regression, I think this is a good change to be included in 5.0. I'll be
backporting the mentioned revision and the previous one that make some
Selenium tests more robust.
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):
In [changeset:"9fe12b0f364b18926ef52587d4dbe2b2901b2b98" 9fe12b0]:
{{{
#!CommitTicketReference repository=""
revision="9fe12b0f364b18926ef52587d4dbe2b2901b2b98"
[5.0.x] Refs #34995 -- Made Selenium tests more robust for admin_views and
admin_widgets suites.
Depending on screen sizes, the selenium tests that would "click" or
interact
with an element outside the scope of the visible window would produce test
failures (raising ElementNotInteractableException in CI runs).
This branch switches those to using ActionChains, which ensures that the
click
(or other interaction) is performed only after successfully completing the
move to the relevant element.
Co-authored-by: Tom Carrick <t...@carrick.eu>
Backport of af2fd368156439b79e4c1eb2278c433246771e44 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Tom Carrick | Owner: Tom
| Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Natalia <124304+nessita@…>):
In [changeset:"471fa926eaa1bb9270e0b0ad0cd8bdd93ea6f88f" 471fa926]:
{{{
#!CommitTicketReference repository=""
revision="471fa926eaa1bb9270e0b0ad0cd8bdd93ea6f88f"
[5.0.x] Fixed #34995 -- Improved position of related widget's add link on
admin pages on small screens.
Regression in 1699f8b52ac15f687cc39088401c2641022c71cd.
Co-authored-by: Sarah Boyce <42296566+...@users.noreply.github.com>
Co-authored-by: Natalia Bidart <124304+...@users.noreply.github.com>
Backport of 999ba9db6d6331eaa58af77debba42754bcc1a8e from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:15>
Django
Reporter: Tom Carrick | Owner: Tom Carrick
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution: fixed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by Natalia <124304+nessita@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"999ba9db6d6331eaa58af77debba42754bcc1a8e" 999ba9d]:
{{{
#!CommitTicketReference repository=""
revision="999ba9db6d6331eaa58af77debba42754bcc1a8e"
Fixed #34995 -- Improved position of related widget's add link on admin
pages on small screens.
Regression in 1699f8b52ac15f687cc39088401c2641022c71cd.
Co-authored-by: Sarah Boyce <42296566+...@users.noreply.github.com>
Co-authored-by: Natalia Bidart <124304+...@users.noreply.github.com>
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34995#comment:11>