[Django] #36629: In the admin m2m widget filter_vertical, the “chooseall” button is missing.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component: contrib.admin
Version: 5.2 | Severity: Normal
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------
Currently, the “choose_all” button exists for `filter_horizontal`, but it
is not available when using `filter_vertical`.

**filter_horizontal**

[[Image(horizontal.png)]]

**filter_vertical**

[[Image(vertical.png)]]

I’m not exactly sure why the choose_all button doesn’t exist for
`filter_vertical`.
I don’t think the “choose all” button has a significant impact on page
height.
Unless there’s a specific reason, I believe the choose_all button should
naturally exist for `filter_vertical` as well.

Additionally, the “choose all” button was also not present in versions 4.2
and 5.0.

**5.0**

[[Image(vertical_5.0.png)]]

**4.2**

[[Image(vertical_4.2.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/36629>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------

Reporter: Antoliny | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: 5.2

Severity: Normal | Resolution:

Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------

Changes (by Antoliny):

* Attachment "vertical.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "horizontal.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "vertical_5.0.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "vertical_4.2.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.

---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

---------------------------------+-----------------------------------------
Changes (by Alex Hatfield):

* owner: (none) => Alex Hatfield
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:1>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Alex Hatfield):

Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a
regression issue, so shifting focus to addressing and implementing a fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:2>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Antoliny):

Replying to [comment:2 Alex Hatfield]:

> Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a
regression issue, so shifting focus to addressing and implementing a fix.

Hello Alex, thank you for choosing to work on this.
However, this ticket has not been accepted yet, so it’s fine to start
after it has been accepted :)
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:3>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:

Keywords: filter_vertical | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

Comment:

Perhaps this was because the buttons were not responsive (#35924), and so
it makes sense to include these.
I think `filter_vertical` should be roughly equivalent to the mobile view
of `filter_horizontal`
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:4>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+------------------------------------

Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new

Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------

Changes (by Alex Hatfield):

* owner: Alex Hatfield => (none)
* status: assigned => new

Comment:

Hi Antoliny, thanks for the comment - apologies for causing any confusion,
will be sure to wait for acceptance next time.
I haven't been able to make any progress so deassigning myself. I believe
I've done this correctly but please let me know if not (apologies this is
my first ticket).
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:5>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------

Comment (by Antoliny):

Replying to [comment:5 Alex Hatfield]:

> Hi Antoliny, thanks for the comment - apologies for causing any
confusion, will be sure to wait for acceptance next time.
> I haven't been able to make any progress so deassigning myself. I
believe I've done this correctly but please let me know if not (apologies
this is my first ticket).

No worries Alex, thank you for giving this ticket a try!
It’s totally fine to start working before accepted — I just mentioned it
because I didn’t want your efforts to go to waste in case it didn’t get
accepted.
You’re welcome to pick this up again anytime! (Now that it’s accepted, as
long as no one else has taken over!)
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:6>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+------------------------------------

Reporter: Antoliny | Owner: Mridul
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------

Changes (by Mridul):

* owner: (none) => Mridul

* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:7>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Mridul
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------

Comment (by Md. Miftahul Kabir):

Replying to [comment:7 Mridul]:
Hello Mridul, can I change the owner to me? I already solved this ticket
for my personal practice and I was able to solve the issue. If you think
it's okay then I can change the owner status to me and create a pull
request.
Thank you
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:8>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+------------------------------------
Reporter: Antoliny | Owner: Mridul
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+------------------------------------

Comment (by Mridul):

Hey,
Yes, no problem please feel free to go agead and do that
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:9>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.

-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Md.
| Miftahul Kabir

Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Md. Miftahul Kabir):

* owner: Mridul => Md. Miftahul Kabir

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:10>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Md.
| Miftahul Kabir
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Md. Miftahul Kabir):

* has_patch: 0 => 1

Comment:

PR link: https://github.com/django/django/pull/19942
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:11>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Md.
| Miftahul Kabir
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Antoliny):

* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:12>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
-------------------------------------+-------------------------------------
Reporter: Antoliny | Owner: Md.
| Miftahul Kabir
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by nileshpahari):

Hi! Since this has been open for a while, can I pick it up? I’m new to the
codebase and this would be my first contribution.
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:13>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.

---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Nilesh Pahari

Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

---------------------------------+-----------------------------------------
Changes (by Nilesh Pahari):

* owner: Md. Miftahul Kabir => Nilesh Pahari

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:14>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Nilesh Pahari
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Nilesh Pahari):

Hi,
It looks like @Md. Miftahul Kabir already fixed the issues and only the
tests are needed, should I create a new PR adding tests along with the
code written by @Md. Miftahul Kabir and mention him?
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:15>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Nilesh Pahari
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Jacob Walls):

Yes, please add co-authored-by in the commit message, check `git log` for
examples or see online tutorials.
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:16>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Nilesh Pahari
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Nilesh Pahari):

PR link: https://github.com/django/django/pull/20396
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:17>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Nilesh Pahari
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Changes (by Nilesh Pahari):

* needs_tests: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:18>