[Django] #36629: In the admin m2m widget filter_vertical, the “chooseall” button is missing.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Type: Bug
Status: new | Component: contrib.admin
Version: 5.2 | Severity: Normal
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------
Currently, the “choose_all” button exists for `filter_horizontal`, but it
is not available when using `filter_vertical`.

**filter_horizontal**

[[Image(horizontal.png)]]

**filter_vertical**

[[Image(vertical.png)]]

I’m not exactly sure why the choose_all button doesn’t exist for
`filter_vertical`.
I don’t think the “choose all” button has a significant impact on page
height.
Unless there’s a specific reason, I believe the choose_all button should
naturally exist for `filter_vertical` as well.

Additionally, the “choose all” button was also not present in versions 4.2
and 5.0.

**5.0**

[[Image(vertical_5.0.png)]]

**4.2**

[[Image(vertical_4.2.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/36629>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------

Reporter: Antoliny | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: 5.2

Severity: Normal | Resolution:

Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------

Changes (by Antoliny):

* Attachment "vertical.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "horizontal.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "vertical_5.0.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+--------------------------------------
Reporter: Antoliny | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+--------------------------------------
Changes (by Antoliny):

* Attachment "vertical_4.2.png" added.

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.

---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1

---------------------------------+-----------------------------------------
Changes (by Alex Hatfield):

* owner: (none) => Alex Hatfield
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:1>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Alex Hatfield):

Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a
regression issue, so shifting focus to addressing and implementing a fix.
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:2>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: filter_vertical | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Comment (by Antoliny):

Replying to [comment:2 Alex Hatfield]:

> Bug observed in Django 5.2.4 and 5.1.12 -> indicating this is not a
regression issue, so shifting focus to addressing and implementing a fix.

Hello Alex, thank you for choosing to work on this.
However, this ticket has not been accepted yet, so it’s fine to start
after it has been accepted :)
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:3>

[Django]

#36629: In the admin m2m widget filter_vertical, the “choose all” button is
missing.
---------------------------------+-----------------------------------------
Reporter: Antoliny | Owner: Alex Hatfield
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:

Keywords: filter_vertical | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
---------------------------------+-----------------------------------------

Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

Comment:

Perhaps this was because the buttons were not responsive (#35924), and so
it makes sense to include these.
I think `filter_vertical` should be roughly equivalent to the mobile view
of `filter_horizontal`
--
Ticket URL: <https://code.djangoproject.com/ticket/36629#comment:4>