[Django] #20542: pymysql breaks last_executed_query()
Django
----------------------------------------------+--------------------
Reporter: christian.oudard@… | Owner: nobody
Type: Bug | Status: new
Component: Database layer (models, ORM) | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
----------------------------------------------+--------------------
In last_executed_query(), the value returned by cursor._last_executed is
unconditionally decoded as utf8. This presumes that it is a byte string
with utf8 encoding.
On the MySQLdb driver, this is true, but on pymysql, it returns a unicode
string instead. This prevents anyone from running queries containing
unicode characters in debug mode while using pymysql.
I can make a patch for this if necessary.
--
Ticket URL: <https://code.djangoproject.com/ticket/20542>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: christian.oudard@… | Owner: nobody
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by akaariai):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
Comment:
Patches welcome.
--
Ticket URL: <https://code.djangoproject.com/ticket/20542#comment:1>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by russellm):
Is PyMySQL really a drop in replacement for MySQLdb? It looks to me like
the base package name is different, so I don't see how it is possible that
this works at all without either an import shim, or a completely different
database backend.
--
Ticket URL: <https://code.djangoproject.com/ticket/20542#comment:2>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by claudep):
I have a branch which more or less supports PyMySQL.
https://github.com/claudep/django/compare/pymysql
Quoting Alex (regarding the above branch):
''The right way to do this type of thing is to really split the adapter
part of a database backend away from the database part of it. So we can
easily have PyMySQL, MySQLdb, psycopg2, pg8000, py-postgresql, postgresql-
ctypes, and whatever else shows up, without needing to continually add to
the chain of `except ImportError`.''
--
Ticket URL: <https://code.djangoproject.com/ticket/20542#comment:3>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: new
(models, ORM) | Resolution:
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 0 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
* cc: cmawebsite@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/20542#comment:4>
Django
-------------------------------------+-------------------------------------
Type: Bug | Status: closed
Component: Database layer | Version: 1.5
(models, ORM) |
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by collinanderson):
* status: new => closed
* resolution: => wontfix
Comment:
Closing now that mysqlclient is our official recommended connector.
--
Ticket URL: <https://code.djangoproject.com/ticket/20542#comment:5>