Re: [Django] #15101: GeoQuerySet extent() method fails to limit

9 views
Skip to first unread message

Django

unread,
Nov 15, 2014, 8:09:56 AM11/15/14
to django-...@googlegroups.com
#15101: GeoQuerySet extent() method fails to limit
----------------------------+------------------------------------
Reporter: billtown@… | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: extent() | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------

Comment (by reinout):

As you say, it isn' just an extent() problem, but also sum() and count().

Turns out, there is a ticket for the generic case of aggregates not
working with limits: #12886

It is fixed in
https://github.com/django/django/commit/7737305a4f5dc5006d92dac3a61523ad6c2a523a,
you'll see some "force_subquery" lines in there, which matches your
comment of "In future versions if a subselect were used..."

Extra note: the fix is in 1.7 and higher.

--
Ticket URL: <https://code.djangoproject.com/ticket/15101#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 15, 2014, 9:52:01 AM11/15/14
to django-...@googlegroups.com
#15101: GeoQuerySet extent() method fails to limit
----------------------------+------------------------------------
Reporter: billtown@… | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: extent() | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------

Comment (by jsmits):

I made a pull request that demonstrates that this indeed has been fixed.
It can be found here: https://github.com/django/django/pull/3532

--
Ticket URL: <https://code.djangoproject.com/ticket/15101#comment:7>

Django

unread,
Nov 15, 2014, 11:02:10 AM11/15/14
to django-...@googlegroups.com
#15101: GeoQuerySet extent() method fails to limit
----------------------------+------------------------------------
Reporter: billtown@… | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: extent() | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------

Comment (by charettes):

Looks like this hasn't been fixed on Spatialite and Oracle.

--
Ticket URL: <https://code.djangoproject.com/ticket/15101#comment:8>

Django

unread,
Jan 16, 2015, 2:13:45 PM1/16/15
to django-...@googlegroups.com
#15101: GeoQuerySet extent() method fails to limit
----------------------------+------------------------------------
Reporter: billtown@… | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.2
Severity: Normal | Resolution:
Keywords: extent() | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------

Comment (by Claude Paroz <claude@…>):

In [changeset:"374c2419e5adef53a643bf69c4753a6bf0c78a98"]:
{{{
#!CommitTicketReference repository=""
revision="374c2419e5adef53a643bf69c4753a6bf0c78a98"
Tested that geo aggregates support slicing

Refs #15101. Patch slightly reworked by Claude Paroz.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/15101#comment:9>

Django

unread,
Jan 16, 2015, 2:47:13 PM1/16/15
to django-...@googlegroups.com
#15101: GeoQuerySet extent() method fails to limit
----------------------------+------------------------------------
Reporter: billtown@… | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.2
Severity: Normal | Resolution: fixed

Keywords: extent() | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
----------------------------+------------------------------------
Changes (by claudep):

* status: new => closed
* resolution: => fixed


--
Ticket URL: <https://code.djangoproject.com/ticket/15101#comment:10>

Reply all
Reply to author
Forward
0 new messages