[Django] #24151: GeoAggregate.prepare is never called
Django
--------------------------------------+---------------------------
Reporter: claudep | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.8alpha1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------+---------------------------
`GeoAggregate.prepare` has been added in
f59fd15c4928caf3dfcbd50f6ab47be409a43b01, however it is apparently never
called from anywhere. Josh, an idea?
--
Ticket URL: <https://code.djangoproject.com/ticket/24151>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: claudep | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.8alpha1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by jarshwah):
Replying to [ticket:24151 claudep]:
> `GeoAggregate.prepare` has been added in
f59fd15c4928caf3dfcbd50f6ab47be409a43b01, however it is apparently never
called from anywhere. Josh, an idea?
Yes, that should be `resolve_expression` now. It must have been overlooked
when we change the name of the method. It obviously needs a test too if
none of the existing tests failed.
--
Ticket URL: <https://code.djangoproject.com/ticket/24151#comment:1>
Django
Reporter: claudep | Owner: nobody
Type: Bug | Status: new
Component: GIS | Version: 1.8alpha1
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
In the patch for #24152 (https://github.com/django/django/pull/3920) I've
moved that check in `check_spatial_aggregate`. If you think this is an
acceptable resolution, feel free to close this ticket.
--
Ticket URL: <https://code.djangoproject.com/ticket/24151#comment:2>
Django
Reporter: claudep | Owner: nobody
Type: Bug | Status: closed
Component: GIS | Version: 1.8alpha1
Severity: Normal | Resolution: duplicate
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by jarshwah):
* status: new => closed
* resolution: => duplicate
--
Ticket URL: <https://code.djangoproject.com/ticket/24151#comment:3>