[Django] #34638: Rows are selected if BooleanField is in list_editable

[Django]

#34638: Rows are selected if BooleanField is in list_editable
--------------------------------------------+------------------------
Reporter: Andrei Shabanski | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 1 |
--------------------------------------------+------------------------
If BooleanField is list_ediable and it stores `True`, the row will be
highlighted on the changelist view. That row isn't selected for bulk
actions though.

Ref #33491

--
Ticket URL: <https://code.djangoproject.com/ticket/34638>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#34638: Rows are selected if BooleanField is in list_editable

----------------------------------+--------------------------------------

Reporter: Andrei Shabanski | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2

Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

----------------------------------+--------------------------------------
Description changed by Andrei Shabanski:

Old description:

> If BooleanField is list_ediable and it stores `True`, the row will be
> highlighted on the changelist view. That row isn't selected for bulk
> actions though.
>
> Ref #33491

New description:

If BooleanField is list_ediable and it stores `True`, the row will be
highlighted on the changelist view. That row isn't selected for bulk
actions though.

[[Image(https://imgur.com/a/kLZUvyM)]]

Ref #33491

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:1>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+--------------------------------------
Reporter: Andrei Shabanski | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+--------------------------------------
Description changed by Andrei Shabanski:

Old description:

> If BooleanField is list_ediable and it stores `True`, the row will be
> highlighted on the changelist view. That row isn't selected for bulk
> actions though.
>

> [[Image(https://imgur.com/a/kLZUvyM)]]
>
> Ref #33491

New description:

If BooleanField is list_ediable and it stores `True`, the row will be
highlighted on the changelist view. That row isn't selected for bulk
actions though.

[[Image(https://i.imgur.com/4zxrKSe.png)]]

Ref #33491

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:2>

[Django]

#34638: Rows are selected if BooleanField is in list_editable

----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned

Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

----------------------------------+----------------------------------------
Changes (by Neeraj Kumar):

* cc: Neeraj Kumar (added)
* owner: nobody => Neeraj Kumar
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:3>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------
Changes (by Neeraj Kumar):

* has_patch: 0 => 1

Old description:

> If BooleanField is list_ediable and it stores `True`, the row will be
> highlighted on the changelist view. That row isn't selected for bulk
> actions though.
>

> [[Image(https://i.imgur.com/4zxrKSe.png)]]
>
> Ref #33491

New description:

If BooleanField is list_ediable and it stores `True`, the row will be
highlighted on the changelist view. That row isn't selected for bulk
actions though.

[[Image(https://i.imgur.com/4zxrKSe.png)]]

Ref #33491

[https://github.com/django/django/pull/16951]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:4>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------

Comment (by Neeraj Kumar):

[https://github.com/django/django/pull/16951]

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:5>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------

Changes (by David Sanders):

* stage: Unreviewed => Accepted

Comment:

Thanks for the report 👍

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:6>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2

Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------
Changes (by David Sanders):

* cc: Marcelo Galigniana, Carlton Gibson (added)
* severity: Normal => Release blocker

Comment:

Regression in 0aa2f16e63887d6053f6fd0da19254fc74c750ae

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:7>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------

Old description:

> If BooleanField is list_ediable and it stores `True`, the row will be
> highlighted on the changelist view. That row isn't selected for bulk
> actions though.
>
> [[Image(https://i.imgur.com/4zxrKSe.png)]]
>
> Ref #33491
>

> [https://github.com/django/django/pull/16951]

New description:

If BooleanField is list_ediable and it stores `True`, the row will be
highlighted on the changelist view. That row isn't selected for bulk
actions though.

[[Image(https://i.imgur.com/4zxrKSe.png)]]

Ref #33491

--

Comment (by David Sanders):

Neeraj it's not necessary to add PR links in the description as well as
your comment ;)

PRs are automatically linked (see the "Pull Requests:" bit at the top).
Some people like to see PRs in the comments too 🤷‍♂️ But I'd leave it
out of the description as it looks like the reporter added it.

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:8>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------

Comment (by Neeraj Kumar):

The description was added by mistake. ☻

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:9>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_docs: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:10>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
----------------------------------+----------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
----------------------------------+----------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 1 => 0
* needs_docs: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:11>

[Django]

#34638: Rows are selected if BooleanField is in list_editable

-------------------------------------+-------------------------------------

Reporter: Andrei Shabanski | Owner: Neeraj
| Kumar
Type: Bug | Status: assigned
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution:

Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:12>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
-------------------------------------+-------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj
| Kumar

Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"1d9d32389c652edc56ada65116d39789896f4820" 1d9d3238]:
{{{
#!CommitTicketReference repository=""
revision="1d9d32389c652edc56ada65116d39789896f4820"
Fixed #34638 -- Fixed admin change list selected row highlight on editable
boolean fields.

Regression in 0aa2f16e63887d6053f6fd0da19254fc74c750ae.

Thanks Andrei Shabanski for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:13>

[Django]

#34638: Rows are selected if BooleanField is in list_editable
-------------------------------------+-------------------------------------
Reporter: Andrei Shabanski | Owner: Neeraj
| Kumar
Type: Bug | Status: closed
Component: contrib.admin | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"9e9a286bed4757b6f7ed2b6d5f0296203d99a15f" 9e9a286b]:
{{{
#!CommitTicketReference repository=""
revision="9e9a286bed4757b6f7ed2b6d5f0296203d99a15f"
[4.2.x] Fixed #34638 -- Fixed admin change list selected row highlight on
editable boolean fields.

Regression in 0aa2f16e63887d6053f6fd0da19254fc74c750ae.

Thanks Andrei Shabanski for the report.

Backport of 1d9d32389c652edc56ada65116d39789896f4820 from main.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34638#comment:14>