[Django] #32842: Refactor out a _check_token() method of CsrfViewMiddleware

[Django]

#32842: Refactor out a _check_token() method of CsrfViewMiddleware
-------------------------------------+-------------------------------------
Reporter: Chris | Owner: Chris Jerdonek
Jerdonek |
Type: | Status: assigned
Cleanup/optimization |
Component: CSRF | Version: dev
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
This ticket is to refactor the following 40 lines of
`CsrfViewMiddleware.process_view()`:
https://github.com/django/django/blob/854e9b066850b9b4eb1171966e996322b2c16d27/django/middleware/csrf.py#L377-L417
into a new `CsrfViewMiddleware._check_token()` method, similar to how
[https://github.com/django/django/blob/854e9b066850b9b4eb1171966e996322b2c16d27/django/middleware/csrf.py#L372-L375
CsrfViewMiddleware._check_referer()] was done in #32596. This would group
together all of the token-related logic and further reduce the size of
`process_view(), which is currently 90 lines long.

--
Ticket URL: <https://code.djangoproject.com/ticket/32842>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#32842: Refactor out a _check_token() method of CsrfViewMiddleware
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned
Component: CSRF | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* stage: Unreviewed => Accepted

Comment:

OK, continuing the effort to make this more generally comprehensible +1.
Thanks.

--
Ticket URL: <https://code.djangoproject.com/ticket/32842#comment:1>

[Django]

#32842: Refactor out a _check_token() method of CsrfViewMiddleware
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned

Component: CSRF | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Chris Jerdonek):

PR: https://github.com/django/django/pull/14524

--
Ticket URL: <https://code.djangoproject.com/ticket/32842#comment:2>

[Django]

#32842: Refactor out a _check_token() method of CsrfViewMiddleware
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek
Cleanup/optimization | Status: assigned

Component: CSRF | Version: dev

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Chris Jerdonek):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/32842#comment:3>

[Django]

#32842: Refactor out a _check_token() method of CsrfViewMiddleware
-------------------------------------+-------------------------------------

Reporter: Chris Jerdonek | Owner: Chris
Type: | Jerdonek

Cleanup/optimization | Status: closed
Component: CSRF | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"ee408309d2007ecec4f43756360bd855d424cbf6" ee408309]:
{{{
#!CommitTicketReference repository=""
revision="ee408309d2007ecec4f43756360bd855d424cbf6"
Fixed #32842 -- Refactored out CsrfViewMiddleware._check_token().
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32842#comment:4>