[Django] #34318: Django 4.1 release notes - document #6106

13 views
Skip to first unread message

Django

unread,
Feb 7, 2023, 9:16:41 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-----------------------------------------+------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: 4.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
I didn't find any documentation of #6106 in Django 4.1 release notes
(Prevented makemessages from changing .po files when up to date). I think
this should be documented.

--
Ticket URL: <https://code.djangoproject.com/ticket/34318>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Feb 7, 2023, 9:17:02 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------

Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by אורי):

* component: Uncategorized => Documentation


--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:1>

Django

unread,
Feb 7, 2023, 9:24:55 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by Tim Graham):

It looks like a bug fix, not a new feature. Why would you document it?

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:2>

Django

unread,
Feb 7, 2023, 9:37:48 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by אורי):

It's a change after 15 years of updating this line every time
`makemessages` was called. If it was a bug it wouldn't persist for 15
years.

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:3>

Django

unread,
Feb 7, 2023, 9:41:02 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by אורי):

Also, Claude Paroz wrote: "IMHO this is clearly a wontfix issue, as jezdez
stated. It is perfectly legitimate to update POT-Creation-Date each time a
po file is updated.". So I don't think it was a bug.

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:4>

Django

unread,
Feb 7, 2023, 9:43:20 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by Tim Graham):

Is it causing you problems? Should it be documented as a backward
incompatible change? How would you document it?

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:5>

Django

unread,
Feb 7, 2023, 9:48:17 AM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by אורי):

Yes, I ran `make_messages` and was surprised that no files have changed. I
expected each .po file to have one line changed.

How would I document it? Something like "`makemessages` - .po files will
not change if there is no change in translations. Formerly `POT-Creation-
Date` was always updated."

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:6>

Django

unread,
Feb 7, 2023, 1:30:03 PM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by Mariusz Felisiak):

I'm confused. We reopened #6106 after reaching a consensus on the
[https://groups.google.com/g/django-developers/c/8QK4MYIE-
Us/m/oNygOdHTAwAJ mailing list]. Moreover, you were in favor of #6106:

> "I also find it annoying that one line changes always even if there are
no changes in translations. I prefer the file not to change at all if
nothing has changed."
and Claude summed up the discussion with:

> "As the won't fixer person 11 years ago, I'm also more in favour of the
change now, even if it changes a bit the meaning of POT-Creation-Date from
"last time the pot file was updated" to "last time a change was detected
in the pot file"."

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:7>

Django

unread,
Feb 7, 2023, 7:32:50 PM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Ad Timmering):

* cc: Ad Timmering (added)


--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:8>

Django

unread,
Feb 7, 2023, 9:55:59 PM2/7/23
to django-...@googlegroups.com
#34318: Django 4.1 release notes - document #6106
-------------------------------+--------------------------------------
Reporter: אורי | Owner: nobody
Type: Uncategorized | Status: new
Component: Documentation | Version: 4.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by אורי):

Hi Mariusz. I like this change and I'm not asking to revert it. I just
think it should be documented in the Django release notes.

--
Ticket URL: <https://code.djangoproject.com/ticket/34318#comment:9>

Reply all
Reply to author
Forward
0 new messages