[Django] #29463: add pagination to stacked inline and tabular inline
Django
-----------------------------------------+------------------------
Reporter: oliver | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: 2.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
Currently, inlines on the django admin page do not have pagination.
So, if there are too many tuple in the inline, page can't be loaded.
How about adding pagination to theme?
I could develop the feature
--
Ticket URL: <https://code.djangoproject.com/ticket/29463>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: oliver | Owner: oliver
Type: New feature | Status: assigned
Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by oliver):
* status: new => assigned
* owner: nobody => oliver
--
Ticket URL: <https://code.djangoproject.com/ticket/29463#comment:1>
Django
Reporter: oliver | Owner: oliver
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by oliver:
Old description:
> Currently, inlines on the django admin page do not have pagination.
> So, if there are too many tuple in the inline, page can't be loaded.
> How about adding pagination to theme?
> I could develop the feature
New description:
Currently, inlines on the django admin page do not have pagination.
So, if there are too many tuple in the inline, page can't be loaded.
How about adding pagination to them?
I could develop the feature
--
--
Ticket URL: <https://code.djangoproject.com/ticket/29463#comment:2>
Django
Reporter: oliver | Owner: oliver
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Matthew Schinckel):
Something that springs to mind is that without having all of the data in
the request, it's not really possible to infer what the user wants to
keep, and what the user wants to delete.
--
Ticket URL: <https://code.djangoproject.com/ticket/29463#comment:3>
Django
Reporter: oliver | Owner: oliver
Type: New feature | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by oliver):
Replying to [comment:3 Matthew Schinckel]:
So, i made this ticket because i want to know other people's opinion.
> Something that springs to mind is that without having all of the data in
the request, it's not really possible to infer what the user wants to
keep, and what the user wants to delete.
--
Ticket URL: <https://code.djangoproject.com/ticket/29463#comment:4>
Django
Reporter: oliver | Owner: oliver
Component: contrib.admin | Version: 2.1
Severity: Normal | Resolution: needsinfo
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Carlton Gibson):
* status: assigned => closed
* resolution: => needsinfo
Comment:
Hi @olivier.
At first glance this seems like a "Yeah, why not?" kind of suggestion. But
it's not addressable in it's current state, so I'm going to mark it
`needsinfo`.
Reason: Adding pagination here is not going to be simple. As such, it
needs **some** idea of how it would be implemented to see if it's
reasonable.
There's also a question at to whether it's worth the effort. Are users
coming up against memory limits on inlines enough to justify the changes?
(I don't know the answer to that.)
My suggestion is to look at
[https://github.com/django/django/blob/3cf45af3630890ad85112f9ea8af869c8daef17b/django/contrib/admin/options.py#L580-L600
`get_inline_instances()`] and come up with a rough and brief outline of
the changes that would be required to support pagination. (Pulling offset
parameters from the request etc — what would the query string look like
for that?, where would we process the form to validate that?, how
would/could we leverage the existing pagination?, and so on.)
With that rough sketch in hand, I'd then post to the mailing list
explaining the proposal and see if there was some appetite. (Better there
than here, simple because you'll get some response there from the larger
audience.) Assuming some uptake, we can then flesh out the description
here and re-open with an eye to implementing it.
Thanks for the effort!
--
Ticket URL: <https://code.djangoproject.com/ticket/29463#comment:5>