Re: [Django] #34059: Validation of check constraints on JSONField key transforms with None produces invalid SQL on PostgreSQL.

20 views
Skip to first unread message

Django

unread,
Sep 28, 2022, 8:48:01 AM9/28/22
to django-...@googlegroups.com
#34059: Validation of check constraints on JSONField key transforms with None
produces invalid SQL on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Dan LaManna | Owner: David
| Sanders
Type: Bug | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by David Sanders):

* needs_better_patch: 0 => 1
* has_patch: 0 => 1


Comment:

PR: https://github.com/django/django/pull/16131

Marking as "needs improvement" as some discussion needs to be had.

--
Ticket URL: <https://code.djangoproject.com/ticket/34059#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Oct 11, 2022, 6:20:02 AM10/11/22
to django-...@googlegroups.com
#34059: Validation of check constraints on JSONField key transforms with None
produces invalid SQL on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Dan LaManna | Owner: David
| Sanders
Type: New feature | Status: assigned

Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* type: Bug => New feature
* severity: Release blocker => Normal


--
Ticket URL: <https://code.djangoproject.com/ticket/34059#comment:8>

Django

unread,
Oct 12, 2022, 5:51:00 AM10/12/22
to django-...@googlegroups.com
#34059: Validation of check constraints on JSONField key transforms with None
produces invalid SQL on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Dan LaManna | Owner: David
| Sanders
Type: New feature | Status: assigned
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by GitHub <noreply@…>):

In [changeset:"004f985b918d5ea36fbed9b050459dd22edaf396" 004f985b]:
{{{
#!CommitTicketReference repository=""
revision="004f985b918d5ea36fbed9b050459dd22edaf396"
Refs #34059 -- Doc'd lack of support for validation of constraints with
JSONFields.

Thanks Dan LaManna for the report.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/34059#comment:9>

Django

unread,
Mar 18, 2024, 8:55:21 AM3/18/24
to django-...@googlegroups.com
#34059: Validation of check constraints on JSONField key transforms with None
produces invalid SQL on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Dan LaManna | Owner: David
| Sanders
Type: New feature | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* resolution: => fixed
* status: assigned => closed

Comment:

Fixed in 09ffc5c1212d4ced58b708cbbf3dfbfb77b782ca.
--
Ticket URL: <https://code.djangoproject.com/ticket/34059#comment:10>

Django

unread,
Mar 18, 2024, 11:11:51 AM3/18/24
to django-...@googlegroups.com
#34059: Validation of check constraints on JSONField key transforms with None
produces invalid SQL on PostgreSQL.
-------------------------------------+-------------------------------------
Reporter: Dan LaManna | Owner: David
| Sanders
Type: New feature | Status: closed
Component: Database layer | Version: 4.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by GitHub <noreply@…>):

In [changeset:"9c17010358891c73417ec569df4f568c0671c099" 9c17010]:
{{{#!CommitTicketReference repository=""
revision="9c17010358891c73417ec569df4f568c0671c099"
Refs #34059, Refs #34060 -- Removed outdated warning about validation of
JSONField constraints.

Known issues have been fixed in:
- 0d8fbe2ade29f1b7bd9e6ba7a0281f5478603a43,
- c991602ce5798385261381025c06698d7fd30dc5, and
- 26aae5614487f58ddb1df5726224393887373ecd.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/34059#comment:11>
Reply all
Reply to author
Forward
0 new messages