[Django] #33817: Use python-oracledb instead of cx-oracle
Django
-----------------------------------------+------------------------
Reporter: GamePad64 | Owner: nobody
Type: Uncategorized | Status: new
Component: Uncategorized | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-----------------------------------------+------------------------
There is a new library for Oracle databases: https://oracle.github.io
/python-oracledb/.
It is intended to replace cx-oracle eventually, and it is fully compatible
with it. It supports so-called “thin” mode, which can be used without
installing Oracle binary client libraries.
That could be beneficial in some scenarios.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: GamePad64 | Owner: nobody
Type: New feature | Status: new
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* cc: Florian Apolloner, Christopher Jones (added)
* keywords: => oracle
* type: Uncategorized => New feature
* component: Uncategorized => Database layer (models, ORM)
* stage: Unreviewed => Accepted
Comment:
Thanks for the report, see the [https://groups.google.com/g/django-
developers/c/Zrq94HLxp0k django-developers thread] for a discussion of
potential ways to move this forward:
> I'd prefer adding support for `python-oracledb` in Django 4.2 and
immediately deprecate using `cx_Oracle` (will be removed in Django 5.1).
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:1>
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => assigned
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
* owner: nobody => petronny
* needs_docs: 0 => 1
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/15841 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: petronny
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Colin Murtaugh (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: petronny
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* needs_docs: 1 => 0
Comment:
I've fixed the patch, tests and documentation. And this ticket is now
ready for review.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:4>
Django
-------------------------------------+-------------------------------------
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: Marti Raudsepp (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
* needs_tests: 0 => 1
* needs_docs: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_tests: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Suraj Shaw):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* stage: Ready for checkin => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:11>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* stage: Ready for checkin => Accepted
Comment:
Suraj, why did you changed the status? Oracle tests still crash with this
patch, it's not
[https://docs.djangoproject.com/en/stable/internals/contributing/triaging-
tickets/#ready-for-checkin "ready for checkin"].
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Suraj Shaw):
@Mariusz Felisiak I tested this patch for oracle tests and i am not seeing
any error with 19c db as well as 21c. Shall we change the status from
accepted to ready for checkin?
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
Replying to [comment:14 Suraj Shaw]:
> @Mariusz Felisiak I tested this patch for oracle tests and i am not
seeing any error with 19c db as well as 21c. Shall we change the status
from accepted to ready for checkin?
It crashes on our setup, so it's not ready. We cannot permanently break
our CI.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Suraj Shaw):
Replying to [comment:15 Mariusz Felisiak]:
> Replying to [comment:14 Suraj Shaw]:
> > @Mariusz Felisiak I tested this patch for oracle tests and i am not
seeing any error with 19c db as well as 21c. Shall we change the status
from accepted to ready for checkin?
>
> It crashes on our setup, so it's not ready. We cannot permanently break
our CI.
In the setup integration it seems to be using 19c db. Shall we look out to
upgrade it to 23c. It may or may not resolve the crash issue but it may be
needed at some stage anyway.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
> In the setup integration it seems to be using 19c db. Shall we look out
to upgrade it to 23c. It may or may not resolve the crash issue but it may
be needed at some stage anyway.
Oracle 19c will be supported 4 more years, so I see no reason to bump it
now. First of all it's really time-consuming (at least few days of my
work). Secondly Oracle 23c is not officially supported by `python-
oracledb` or `cx_Oracle`.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:17>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Suraj Shaw):
Replying to [comment:17 Mariusz Felisiak]:
> > In the setup integration it seems to be using 19c db. Shall we look
out to upgrade it to 23c. It may or may not resolve the crash issue but it
may be needed at some stage anyway.
>
> Oracle 19c will be supported 4 more years, so I see no reason to bump it
now. First of all it's really time-consuming (at least few days of my
work). Secondly Oracle 23c is not officially supported by `python-
oracledb` or `cx_Oracle`.
Oracle 23c is officially supported and i guess it may help us to get past
the crash impasse.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:18>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
> Oracle 23c is officially supported and i guess it may help us to get
past the crash impasse.
Again, Oracle 19c will be supported 4 more years, so I see no reason to
bump it now. We cannot drop support for it just because we don't know why
it crashes with this patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:19>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Suraj Shaw):
@Mariusz Felisiak Any leads how shall we proceed further to this PR to
land it as soon as possible since its quite long we have been waiting for
this feature to be present in django.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:20>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Florian Apolloner):
Replying to [comment:20 Suraj Shaw]:
> @Mariusz Felisiak Any leads how shall we proceed further to this PR to
land it as soon as possible since its quite long we have been waiting for
this feature to be present in django.
As Mariusz already pointed out more than once: Oracle 19c is and still
will be supported for a while. So you will need to fix the PR for Oracle
19, once that is done it can get reviewed.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:21>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Christopher Jones):
It's not easy to fix something that doesn't reproduce, and where log files
are not available !
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:22>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Florian Apolloner):
Which logs would be needed? The CI job logs are public. If you think it is
in the Oracle logs, please tell us which logs would be relevant or which
config changes would be required to obtain the necessary logs, then it
would be easier for the people having access to help you.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:23>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Christopher Jones):
We (Oracle) can assist on a live session if we can get someone who can
handle the Django infrastructure questions. We span a few timezones.
What's convenient? Send me email addresses (mine is in my profile
https://github.com/cjbj) to invite.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:24>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Florian Apolloner):
@MarkusH: Can you or someone else from ops help out here (another option
would be to temporarily give me access to the CI boxes again)?
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:25>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mariusz Felisiak):
I can take a look but not in June, maybe in July or August. It's not high
on my priority list. I've already spent too much time in June keeping the
Oracle backend as functional as the others. As far as I'm aware, it's an
issue in `python-oracledb` or one of the libraries it uses. Of course, we
will help you (Oracle) with debugging, even considering the fact that
you've never helped us maintain the Oracle backend by providing
infrastructure, knowledge, or money. You have to wait patiently like
everyone else. It's an open-source.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:26>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Suraj Shaw):
After following the logs that has been uploaded , it looks like it is
crashing inside the code that is displaying all of the variables in the
stack. In the debugging code if it can be disabled it may help us to find
out what the real issue is.
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:27>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: oracle | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:28>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Type: New feature | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:29>
Django
-------------------------------------+-------------------------------------
Reporter: Alexander Shishenko | Owner: Jingbei
| Li
Component: Database layer | Version: dev
(models, ORM) |
Keywords: oracle | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"9946f0b0d9356b55e819f861b31615fa5b548f99" 9946f0b]:
{{{
#!CommitTicketReference repository=""
revision="9946f0b0d9356b55e819f861b31615fa5b548f99"
Fixed #33817 -- Added support for python-oracledb and deprecated
cx_Oracle.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33817#comment:30>