Re: [Django] #13694: SafeMIMEText argument names incompatible with those from MIMEText

[Django]

#13694: SafeMIMEText argument names incompatible with those from MIMEText
-----------------------------+------------------------------------
Reporter: davenaff | Owner: nobody
Type: Bug | Status: new
Component: Core (Mail) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------
Changes (by claudep):

* version: 1.2 => master
* needs_tests: 1 => 0

Comment:

Alternate approach with removal of `__init__`. I don't think we need more
tests here, as this is mostly refactoring.

--
Ticket URL: <https://code.djangoproject.com/ticket/13694#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#13694: SafeMIMEText argument names incompatible with those from MIMEText
-----------------------------+------------------------------------

Reporter: davenaff | Owner: ramiro
Type: Bug | Status: assigned

Component: Core (Mail) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Changes (by ramiro):

* owner: nobody => ramiro
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/13694#comment:7>

[Django]

#13694: SafeMIMEText argument names incompatible with those from MIMEText
-----------------------------+------------------------------------
Reporter: davenaff | Owner: ramiro
Type: Bug | Status: assigned
Component: Core (Mail) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Changes (by timo):

* needs_better_patch: 0 => 1

Comment:

Removing `__init__` doesn't look like an option anymore as there is much
more logic in there now.

--
Ticket URL: <https://code.djangoproject.com/ticket/13694#comment:8>

[Django]

#13694: SafeMIMEText argument names incompatible with those from MIMEText
-----------------------------+------------------------------------
Reporter: davenaff | Owner: ramiro
Type: Bug | Status: assigned
Component: Core (Mail) | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Comment (by berkerpeksag):

https://github.com/django/django/pull/3606

--
Ticket URL: <https://code.djangoproject.com/ticket/13694#comment:9>

[Django]

#13694: SafeMIMEText argument names incompatible with those from MIMEText
-----------------------------+------------------------------------
Reporter: davenaff | Owner: ramiro

Type: Bug | Status: closed

Component: Core (Mail) | Version: master

Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-----------------------------+------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"a5bd7f2cb2ce6d9cf309748be0fe033b836c4507"]:
{{{
#!CommitTicketReference repository=""
revision="a5bd7f2cb2ce6d9cf309748be0fe033b836c4507"
Fixed #13694 -- Made SafeMIMEText's constructor compatible with MIMEText.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/13694#comment:10>