[Django] #32969: Improve pickling of HttpResponse instances
Django
------------------------------------------------+------------------------
Reporter: zatro | Owner: nobody
Type: Bug | Status: new
Component: Core (Serialization) | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
When pickling a HTTPResponse, rather than pickling all of its attributes
just store what is needed for the creation of a new HttpResponse with the
correct content, status code and headers.
See related discussion on ticket #23895 and its PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/32969>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: zatro | Owner: nobody
Type: Bug | Status: new
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* component: Core (Serialization) => HTTP handling
* stage: Unreviewed => Accepted
Comment:
Thanks, it's worth adding that pickling `HttpResponse` with CBV crashes:
{{{
>>> import pickle
>>> response = self.client.get('/cbv_view/')
>>> pickle.dumps(response)
...
AttributeError: Can't pickle ....
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:1>
Django
Reporter: zatro | Owner: tigicion
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by tigicion):
* owner: nobody => tigicion
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:2>
Django
Reporter: zatro | Owner: tigicion
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by tigicion):
* has_patch: 0 => 1
Comment:
https://github.com/django/django/pull/14728
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:3>
Django
Reporter: zatro | Owner: tigicion
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 0 => 1
Comment:
I agree with
[https://github.com/django/django/pull/14728#discussion_r682556877 Keryn's
comment].
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:4>
Django
Reporter: zatro | Owner: Ruoxu Hua
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ruoxu Hua):
* needs_better_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:5>
Django
Reporter: zatro | Owner: tigicion
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Keryn Knight):
* cc: Keryn Knight (added)
* needs_better_patch: 0 => 1
Comment:
Tentatively setting the flag back; I've left feedback and proposed a first
sketch of how adapting `SimpleTemplateResponse` and `TemplateResponse`
might go.
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:6>
Django
Reporter: zatro | Owner: tigicion
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:7>
Django
Reporter: zatro | Owner: Anvesh Mishra
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Changes (by Anvesh Mishra):
* cc: Anvesh Mishra (added)
* owner: tigicion => Anvesh Mishra
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:8>
Django
Reporter: zatro | Owner: Anvesh Mishra
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Comment (by Anvesh Mishra):
Submitted the [https://github.com/django/django/pull/15777 PR] with all
the suggested changes according to Keryn and Felix's comments on
[https://github.com/django/django/pull/14728 PR-14728]
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:9>
Django
Reporter: zatro | Owner: Anvesh
| Mishra
Type: Bug | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:10>
Django
Reporter: zatro | Owner: Anvesh
| Mishra
Component: HTTP handling | Version: dev
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"d7f5bfd241666c0a76e90208da1e9ef81aec44db" d7f5bfd]:
{{{
#!CommitTicketReference repository=""
revision="d7f5bfd241666c0a76e90208da1e9ef81aec44db"
Fixed #32969 -- Fixed pickling HttpResponse and subclasses.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:11>
Django
Reporter: zatro | Owner: Anvesh
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* type: Bug => Cleanup/optimization
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:12>
Django
Reporter: zatro | Owner: Anvesh
Type: | Mishra
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"173034b00589c083793d495e8b07e35be2cb1cf0" 173034b0]:
{{{
#!CommitTicketReference repository=""
revision="173034b00589c083793d495e8b07e35be2cb1cf0"
Refs #34482 -- Reverted "Fixed #32969 -- Fixed pickling HttpResponse and
subclasses."
This reverts commit d7f5bfd241666c0a76e90208da1e9ef81aec44db.
Thanks Márton Salomváry for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:13>
Django
Reporter: zatro | Owner: Anvesh
Type: | Mishra
Cleanup/optimization | Status: closed
Component: HTTP handling | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"791407fef16faa4da6fe2247c24a9055037dd5dd" 791407f]:
{{{
#!CommitTicketReference repository=""
revision="791407fef16faa4da6fe2247c24a9055037dd5dd"
[4.2.x] Refs #34482 -- Reverted "Fixed #32969 -- Fixed pickling
HttpResponse and subclasses."
This reverts commit d7f5bfd241666c0a76e90208da1e9ef81aec44db.
Thanks Márton Salomváry for the report.
Backport of 173034b00589c083793d495e8b07e35be2cb1cf0 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:14>
Django
Reporter: zatro | Owner: Anvesh
Type: | Mishra
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* status: closed => new
* has_patch: 1 => 0
* resolution: fixed =>
* stage: Ready for checkin => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:15>
Django
Reporter: zatro | Owner: Anvesh
Type: | Mishra
Cleanup/optimization | Status: new
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Ülgen Sarıkavak):
* cc: Ülgen Sarıkavak (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:16>
Django
Reporter: zatro | Owner: (none)
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
* owner: Anvesh Mishra => (none)
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:17>
Django
Reporter: zatro | Owner: (none)
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Jacob Walls):
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:18>
Django
Reporter: zatro | Owner: H. White
Type: Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by H. White):
* owner: (none) => H. White
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:19>
Django
Reporter: zatro | Owner: H. White
Type: Cleanup/optimization | Status: assigned
Component: HTTP handling | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Easy pickings: 0 | UI/UX: 0
Changes (by H. White):
Comment:
Several classes associated with HTTP handling have attributes that
reference objects that can't be pickled. Previous fixes have tried
removing the attributes that won't pickle, but since the attributes
weren't replaced, copied or unpickled objects were missing them.
This PR adds {{{__getstate__}}} and {{{__setstate__}}} methods to these
classes, allowing instances to serialize and deserialize properly. I see
that this approach was discussed for #23895
(https://github.com/django/django/pull/14664), and rejected because the
urlconf could have changed after the object was pickled. However, the
unpicklable objects are only present in responses created by the test
client, and the reason for their inclusion is documented.
--
Ticket URL: <https://code.djangoproject.com/ticket/32969#comment:20>