[Django] #32322: Autocomplete widget options wrap issue in CSS

45 views
Skip to first unread message

Django

unread,
Jan 5, 2021, 7:23:07 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor | Owner: Viktor Grabov
Grabov |
Type: Bug | Status: assigned
Component: | Version: master
contrib.admin | Keywords: Autocomplete,
Severity: Normal | contrib.admin, widget
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
There is a problem with autocomplete widget in admin please see attached
screenshot

--
Ticket URL: <https://code.djangoproject.com/ticket/32322>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jan 5, 2021, 7:30:36 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* Attachment "issue.png" added.

Issue screenshot

Django

unread,
Jan 5, 2021, 7:31:45 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Viktor Grabov:

Old description:

> There is a problem with autocomplete widget in admin please see attached
> screenshot

New description:

There is a problem with autocomplete widget in admin please see attached
screenshot

[[Image(issue.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:1>

Django

unread,
Jan 5, 2021, 7:50:48 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* Attachment "Fixed.png" added.

Fixed

Django

unread,
Jan 5, 2021, 7:52:36 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Viktor Grabov:

Old description:

> There is a problem with autocomplete widget in admin please see attached
> screenshot
> [[Image(issue.png)]]

New description:

There is a problem with autocomplete widget in admin please see attached
screenshot

[[Image(issue.png)]]

I am submitting ​PR GH-13846 with my proposed fix.

Screenshot after fix
[[Image(Fixed.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:2>

Django

unread,
Jan 5, 2021, 7:54:05 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* Attachment "Fixed.2.png" added.

Fixed

Django

unread,
Jan 5, 2021, 7:54:37 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* Attachment "Fixed.png" added.

Fixed

Django

unread,
Jan 5, 2021, 8:24:03 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* Attachment "Fixed.png" added.

Fixed

--

Django

unread,
Jan 5, 2021, 8:25:52 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Description changed by Viktor Grabov:

Old description:

> There is a problem with autocomplete widget in admin please see attached
> screenshot


> [[Image(issue.png)]]
>
> I am submitting ​PR GH-13846 with my proposed fix.
>
> Screenshot after fix
> [[Image(Fixed.png)]]

New description:

There is a problem with autocomplete widget in admin please see attached
screenshot

[[Image(issue.png)]]

I am submitting ​PR [https://github.com/django/django/pull/13846] with my
proposed fix.

Screenshot after fix
[[Image(Fixed.png)]]

--

--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:3>

Django

unread,
Jan 5, 2021, 9:14:32 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* owner: Viktor Grabov => Viktor Grabov
* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:4>

Django

unread,
Jan 5, 2021, 9:21:23 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage: Ready for
contrib.admin, widget | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* ui_ux: 0 => 1
* stage: Unreviewed => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:5>

Django

unread,
Jan 5, 2021, 9:26:22 AM1/5/21
to django-...@googlegroups.com
#32322: Autocomplete widget options wrap issue in CSS
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor

| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage:
contrib.admin, widget | Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Viktor Grabov):

* stage: Ready for checkin => Unreviewed


--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:6>

Django

unread,
Jan 6, 2021, 2:14:40 AM1/6/21
to django-...@googlegroups.com
#32322: Incorrect wrapping of autocomplete cleaner on Chrome.

-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor
| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage: Accepted
contrib.admin, widget |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Unreviewed => Accepted


Comment:

Thanks for the report, I was able to reproduce this issue but only on
Chrome.

--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:7>

Django

unread,
Jan 6, 2021, 2:36:00 AM1/6/21
to django-...@googlegroups.com
#32322: Incorrect wrapping of autocomplete cleaner on Chrome.
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor
| Grabov
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: Autocomplete, | Triage Stage: Ready for
contrib.admin, widget | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:8>

Django

unread,
Jan 6, 2021, 3:32:34 AM1/6/21
to django-...@googlegroups.com
#32322: Incorrect wrapping of autocomplete cleaner on Chrome.
-------------------------------------+-------------------------------------
Reporter: Viktor Grabov | Owner: Viktor
| Grabov
Type: Bug | Status: closed
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed

Keywords: Autocomplete, | Triage Stage: Ready for
contrib.admin, widget | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6a054f768136de2caeaecf6c0fe9ffad76281373" 6a054f76]:
{{{
#!CommitTicketReference repository=""
revision="6a054f768136de2caeaecf6c0fe9ffad76281373"
Fixed #32322 -- Fixed autocomplete widget wrapping.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/32322#comment:9>

Reply all
Reply to author
Forward
0 new messages