Re: [Django] #33607: PostgresIndex.create_sql() doesn't respect the using argument.
Django
--------------------------------------+------------------------------------
Reporter: Alexandru Mărășteanu | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Alexandru Mărășteanu):
Replying to [comment:2 Mariusz Felisiak]:
> I agree that `create_sql()` should respect the `using` argument, so the
following diff should be sufficient:
Fine, that works for me. What are the next steps?
--
Also, is it possible to make this available to all (2+) Django versions?
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
--------------------------------------+------------------------------------
Reporter: Alexandru Mărășteanu | Owner: (none)
Type: Cleanup/optimization | Status: new
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Mariusz Felisiak):
> Fine, that works for me. What are the next steps?
You can assign this ticket to yourself and prepare PR (test is required).
> Also, is it possible to make this available to all (2+) Django versions?
No, we don't backport cleanups and new features.
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:4>
Django
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Alexandru Mărășteanu):
* owner: (none) => Alexandru Mărășteanu
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* easy: 0 => 1
Comment:
Alexandru, Do you have time to keep working on this?
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Alexandru Mărășteanu):
Replying to [comment:6 Mariusz Felisiak]:
> Alexandru, Do you have time to keep working on this?
Yes, I'll take care of it this week. Sorry for the delay, I was on
vacation.
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Alexandru Mărășteanu):
https://github.com/django/django/pull/15600
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Severity: Normal | Resolution:
| checkin
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Alexandru | Owner: Alexandru
Mărășteanu | Mărășteanu
Cleanup/optimization |
Component: contrib.postgres | Version: dev
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"a1e4e86f923dc8387b0a9c3025bdd5d096a6ebb8" a1e4e86f]:
{{{
#!CommitTicketReference repository=""
revision="a1e4e86f923dc8387b0a9c3025bdd5d096a6ebb8"
Fixed #33607 -- Made PostgresIndex.create_sql() respect the "using"
argument.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33607#comment:11>