[Django] #28790: Provide a mixin to run certain test classes not in parallel
Django
---------------------------------------------+------------------------
Reporter: Tobias Krönke | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
---------------------------------------------+------------------------
I will submit a PR, in which I propose to enable users to mark tests for
non-parallel execution. In this way, they don't have to make sure, that
all their tests are properly isolated. This is useful, if you work with
other with external storages like e.g. solr and django-haystack.
--
Ticket URL: <https://code.djangoproject.com/ticket/28790>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tobias Krönke | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Tobias Krönke:
Old description:
> I will submit a PR, in which I propose to enable users to mark tests for
> non-parallel execution. In this way, they don't have to make sure, that
> all their tests are properly isolated. This is useful, if you work with
> other with external storages like e.g. solr and django-haystack.
New description:
In PR https://github.com/django/django/pull/9342 I propose to enable users
to mark tests for non-parallel execution. In this way, they don't have to
make sure, that all their tests are properly isolated. This is useful, if
you work with other with external storages like e.g. solr and django-
haystack.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:1>
Django
Reporter: Tobias Krönke | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Description changed by Tobias Krönke:
Old description:
> In PR https://github.com/django/django/pull/9342 I propose to enable
> users to mark tests for non-parallel execution. In this way, they don't
> have to make sure, that all their tests are properly isolated. This is
> useful, if you work with other with external storages like e.g. solr and
> django-haystack.
New description:
In PR https://github.com/django/django/pull/9342 I propose to enable users
to mark tests for non-parallel execution. In this way, they don't have to
make sure, that all their tests are properly isolated. This is useful, if
you work with other external storages like e.g. solr and django-haystack.
--
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:2>
Django
Reporter: Tobias Krönke | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tim Graham):
Isn't this is already provided by
ba813864870d63de1d1679271c38a3c15e94e934? It could probably be documented
if needed.
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:3>
Django
Reporter: Tobias Krönke | Owner: nobody
Type: New feature | Status: new
Component: Testing framework | Version: master
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Tobias Krönke):
I don't want to be too eager for this to be merged. I probably wouldn't
have looked any further had I known this Mixin. Still I would like to
point out some advantages of my solution:
- Less complex to use
- Less complex implementation (especially no lock files involved)
- More efficient, if you have only 1 shared resource (no concurrent waits
for the locked file)
Of course I also see the advantage of the existing mixin, that you can use
different lock files for different shared resources if you have many. A
hint in the docs would be quite pleasant.
So, your call ;-)
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:4>
Django
--------------------------------------+------------------------------------
Reporter: Tobias Krönke | Owner: nobody
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham):
* component: Testing framework => Documentation
* has_patch: 1 => 0
* type: New feature => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
I guess it's better to document the existing class rather than add another
one unless the new implementation is preferred for some reason.
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:5>
Django
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Caio Ariede):
* owner: nobody => Caio Ariede
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Caio Ariede):
[https://github.com/django/django/pull/11445 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Cleanup/optimization | Status: assigned
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"dafdfd6a60638c4edcca7c4e65d11c0af654d759" dafdfd6a]:
{{{
#!CommitTicketReference repository=""
revision="dafdfd6a60638c4edcca7c4e65d11c0af654d759"
Fixed #28790 -- Doc'd how to avoid running certain test classes in
parallel.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"7d8d2b56be12fd573dccba41cbeebfa2cea61534" 7d8d2b56]:
{{{
#!CommitTicketReference repository=""
revision="7d8d2b56be12fd573dccba41cbeebfa2cea61534"
[3.0.x] Fixed #28790 -- Doc'd how to avoid running certain test classes in
parallel.
Backport of dafdfd6a60638c4edcca7c4e65d11c0af654d759 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: Tobias Krönke | Owner: Caio
Type: | Ariede
Cleanup/optimization | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"5e91adc79d2fd79821be43007b99ba9982a0358c" 5e91adc7]:
{{{
#!CommitTicketReference repository=""
revision="5e91adc79d2fd79821be43007b99ba9982a0358c"
[2.2.x] Fixed #28790 -- Doc'd how to avoid running certain test classes in
parallel.
Backport of dafdfd6a60638c4edcca7c4e65d11c0af654d759 from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/28790#comment:11>