Re: [Django] #35056: admin.E013 on ManyToManyField with related_name crashes.

16 views
Skip to first unread message

Django

unread,
Dec 23, 2023, 5:49:26 AM12/23/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
---------------------------------+------------------------------------
Reporter: Thomas Feldmann | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------

Comment (by Salvo Polizzi):

Can i help with this issue? If anyone can give me some advice or reference
to other similar issues, I would like to contribute

--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Dec 23, 2023, 7:24:57 AM12/23/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
---------------------------------+------------------------------------
Reporter: Thomas Feldmann | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------

Comment (by Hrushikesh Vaidya):

Could this be fixed with a simple `hasattr(field.remote_field, 'through')`
check before accessing `through`?

--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:5>

Django

unread,
Dec 24, 2023, 7:01:10 AM12/24/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
-------------------------------------+-------------------------------------
Reporter: Thomas Feldmann | Owner: uktamjon-
| komilov
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by uktamjon-komilov):

* owner: nobody => uktamjon-komilov
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:6>

Django

unread,
Dec 24, 2023, 7:05:00 AM12/24/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
---------------------------------+------------------------------------
Reporter: Thomas Feldmann | Owner: (none)
Type: Bug | Status: new

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Changes (by uktamjon-komilov):

* owner: uktamjon-komilov => (none)
* status: assigned => new


--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:7>

Django

unread,
Dec 27, 2023, 1:58:12 AM12/27/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
-------------------------------------+-------------------------------------
Reporter: Thomas Feldmann | Owner: Mariusz
| Felisiak
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Mariusz Felisiak


* status: new => assigned

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/17647 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:6>

Django

unread,
Dec 27, 2023, 2:36:32 PM12/27/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
-------------------------------------+-------------------------------------
Reporter: Thomas Feldmann | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by GitHub <noreply@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"751d732a3815a68bdb5b7aceda0e7d5981362c4a" 751d732a]:
{{{
#!CommitTicketReference repository=""
revision="751d732a3815a68bdb5b7aceda0e7d5981362c4a"
Fixed #35056 -- Fixed system check crash on reverse m2m relations with
related_name in ModelAdmin.filter_horizontal/vertical.

Thanks Thomas Feldmann for the report.

Regression in 107865780aa44914e21d27fdf4ca269bc61c7f01.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:7>

Django

unread,
Dec 27, 2023, 2:38:00 PM12/27/23
to django-...@googlegroups.com
#35056: admin.E013 on ManyToManyField with related_name crashes.
-------------------------------------+-------------------------------------
Reporter: Thomas Feldmann | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.admin | Version: 5.0
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"9a182f3d959d16354e24f34713df602f1bef6556" 9a182f3d]:
{{{
#!CommitTicketReference repository=""
revision="9a182f3d959d16354e24f34713df602f1bef6556"
[5.0.x] Fixed #35056 -- Fixed system check crash on reverse m2m relations
with related_name in ModelAdmin.filter_horizontal/vertical.

Thanks Thomas Feldmann for the report.

Regression in 107865780aa44914e21d27fdf4ca269bc61c7f01.
Backport of 751d732a3815a68bdb5b7aceda0e7d5981362c4a from main
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/35056#comment:8>

Reply all
Reply to author
Forward
0 new messages