[Django] #30486: Custom aggregate function example needs updating for Django 2.2's `allow_distinct`

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`
------------------------------------------+------------------------
Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 2.2
Severity: Normal | Keywords:
Triage Stage: Accepted | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
#28658 added the `Aggregate.allow_distinct` attribute. The example of the
custom `Count` needs updating to use this.

[https://github.com/django/django/pull/11373 PR] already begun.

--
Ticket URL: <https://code.djangoproject.com/ticket/30486>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`

--------------------------------+------------------------------------

Reporter: Carlton Gibson | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: 2.2

Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

--------------------------------+------------------------------------
Changes (by Carlton Gibson):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/30486#comment:1>

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`

--------------------------------+---------------------------------------
Reporter: Carlton Gibson | Owner: VVyacheslav
Type: Bug | Status: assigned
Component: Documentation | Version: 2.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

--------------------------------+---------------------------------------
Changes (by VVyacheslav):

* status: new => assigned
* owner: nobody => VVyacheslav

--
Ticket URL: <https://code.djangoproject.com/ticket/30486#comment:2>

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`

-------------------------------------+-------------------------------------
Reporter: Carlton Gibson | Owner:
| Vyacheslav V.V.
Type: Bug | Status: assigned
Component: Documentation | Version: 2.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------

Comment (by Vyacheslav V.V.):

I have created [https://github.com/django/django/pull/11376 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/30486#comment:3>

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`

-------------------------------------+-------------------------------------
Reporter: Carlton Gibson | Owner:
| Vyacheslav V.V.
Type: Bug | Status: assigned

Component: Documentation | Version: 2.2
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Vyacheslav V.V.):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/30486#comment:4>

[Django]

#30486: Custom aggregate function example needs updating for Django 2.2's
`allow_distinct`

-------------------------------------+-------------------------------------
Reporter: Carlton Gibson | Owner:
| Vyacheslav V.V.

Type: Bug | Status: closed
Component: Documentation | Version: 2.2
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed

Comment:

In [changeset:"76b3fc5c8d8dffb441aaa08f75833888be2107af" 76b3fc5c]:
{{{
#!CommitTicketReference repository=""
revision="76b3fc5c8d8dffb441aaa08f75833888be2107af"
Fixed #30486 -- Fixed the default value of Aggregate.distinct and updated
example of custom aggregate functions.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/30486#comment:5>