[Django] #32034: Remove duplicate lookup in AdminSite.app_index view
Django
--------------------------------------------+------------------------
Reporter: Raffaele Salmaso | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.admin | Version: 3.1
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
--------------------------------------------+------------------------
`AdminSites.app_index` needs an `app_name` to render title page.
Currently it is retrieved by an `apps.get_app_config` lookup, but the same
name is already present in `app_dict` dictionary
{{{
app_dict[app_label] = {
'name': apps.get_app_config(app_label).verbose_name,
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32034>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Raffaele Salmaso):
* owner: nobody => Raffaele Salmaso
* status: new => assigned
Comment:
PR https://github.com/django/django/pull/13451
--
Ticket URL: <https://code.djangoproject.com/ticket/32034#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
| Salmaso
Type: Uncategorized | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Raffaele Salmaso):
I don't know if this needs testing (I cannot find one)
--
Ticket URL: <https://code.djangoproject.com/ticket/32034#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: 3.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_tests: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/32034#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
Type: | Salmaso
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by felixxm):
* needs_tests: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32034#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Raffaele Salmaso | Owner: Raffaele
Type: | Salmaso
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"666f2e8acdda690f5a87fc5838e36b0c972093ac" 666f2e8]:
{{{
#!CommitTicketReference repository=""
revision="666f2e8acdda690f5a87fc5838e36b0c972093ac"
Refs #32034 -- Added test for title on admin app index view.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32034#comment:6>