[Django] #20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the website

27 views
Skip to first unread message

Django

unread,
May 19, 2013, 6:18:47 AM5/19/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
--------------------------------------+--------------------
Reporter: giuliettamasina | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: *.djangoproject.com | Version:
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
--------------------------------------+--------------------
The copyright info in the footer of Trac says "© 2005-2012 Django Software
Foundation" instead of having 2013 as the upper year, as in the footer on
djangoproject.com

--
Ticket URL: <https://code.djangoproject.com/ticket/20457>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
May 19, 2013, 7:26:07 AM5/19/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
--------------------------------------+------------------------------------

Reporter: giuliettamasina | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
--------------------------------------+------------------------------------
Changes (by aaugustin):

* needs_docs: => 0
* needs_better_patch: => 0
* version: => master
* needs_tests: => 0
* stage: Unreviewed => Accepted


Comment:

It's defined here:
https://github.com/django/code.djangoproject.com/blob/master/trac-
env/templates/site.html#L37

If somone knows the equivalent of `{% now 'Y' %}` in Genshi, that'd help
:)

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:1>

Django

unread,
May 19, 2013, 7:30:14 AM5/19/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned

Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by giuliettamasina):

* owner: nobody => giuliettamasina
* status: new => assigned


--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:2>

Django

unread,
May 20, 2013, 6:08:17 PM5/20/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by svisser):

It seems one can define it using Python's `datetime`:
http://genshi.edgewall.org/wiki/Documentation/templates.html#id1 .

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:3>

Django

unread,
May 21, 2013, 4:04:34 AM5/21/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by giuliettamasina):

Hmm, maybe a bit heavy to import a whole module just to print a simple
year string? Or maybe not; I'm wondering if it could be performance
measured somehow.

I will look into it and propose some sort of change, thanks for the info
svisser :)

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:4>

Django

unread,
May 21, 2013, 4:25:22 AM5/21/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by aaugustin):

I don't expect performance to be an issue. Importing a module is very fast
once it's in `sys.modules`.

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:5>

Django

unread,
May 21, 2013, 5:07:08 AM5/21/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by giuliettamasina):

Cool, I'll send in a pull request for this soonish.

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:6>

Django

unread,
May 22, 2013, 6:26:58 AM5/22/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by bmispelon):

* cc: bmispelon@… (added)
* has_patch: 0 => 1


Comment:

I was playing around a bit and I found that you have access to
`datetime.date` in the `site.html` context.

I couldn't find this documented anywhere so I'm not sure how reliable it
is, but it worked on my local trac instance.

This makes the change rather trivial:
https://github.com/django/code.djangoproject.com/pull/6/files.

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:7>

Django

unread,
May 22, 2013, 6:28:55 AM5/22/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: assigned
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* stage: Accepted => Ready for checkin


Comment:

As long as it works...

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:8>

Django

unread,
May 22, 2013, 6:31:55 AM5/22/13
to django-...@googlegroups.com
#20457: Copyright footer on Trac says "2012" instead of "2013" as the rest of the
website
-------------------------------------+-------------------------------------
Reporter: giuliettamasina | Owner:
Type: | giuliettamasina
Cleanup/optimization | Status: closed
Component: *.djangoproject.com | Version: master
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
Has patch: 1 | checkin
Needs tests: 0 | Needs documentation: 0
Easy pickings: 0 | Patch needs improvement: 0
| UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by aaugustin):

* status: assigned => closed
* resolution: => fixed


Comment:

Fixed in a84118fd335736b358acf4673bccd38d52e00a5e.

--
Ticket URL: <https://code.djangoproject.com/ticket/20457#comment:9>

Reply all
Reply to author
Forward
0 new messages