[Django] #36885: Long verbose names in the admin filter sidebar cause main area to reduce to unusable width

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------+-----------------------------------------
Reporter: Jacob Walls | Type: Bug
Status: new | Component: contrib.admin
Version: 5.2 | Severity: Normal
Keywords: wrap | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------+-----------------------------------------
The test case being added in #36850 reveals at smaller screen sizes, an
infelicity where long verbose names not broken mid-word in the admin
filter sidebar cause the main area to shrink to almost nothing. See
screenshot.
--
Ticket URL: <https://code.djangoproject.com/ticket/36885>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width

-------------------------------+--------------------------------------
Reporter: Jacob Walls | Owner: (none)

Type: Bug | Status: new
Component: contrib.admin | Version: 5.2

Severity: Normal | Resolution:

Keywords: wrap | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-------------------------------+--------------------------------------
Changes (by Jacob Walls):

* Attachment "long-verbose-name-unusable-main-area.png" added.

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width

-----------------------------------+------------------------------------

Reporter: Jacob Walls | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:

Keywords: wrap admin filter | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1

-----------------------------------+------------------------------------
Changes (by Natalia Bidart):

* keywords: wrap => wrap admin filter
* stage: Unreviewed => Accepted

Comment:

Reproduced, thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:1>

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------------+------------------------------------

Reporter: Jacob Walls | Owner: Harsh007
Type: Bug | Status: assigned

Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: wrap admin filter | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+------------------------------------

Changes (by Harsh007):

* cc: Harsh007 (added)
* owner: (none) => Harsh007
* status: new => assigned

Comment:

I can work on this issue and will propose a patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:2>

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------------+------------------------------------
Reporter: Jacob Walls | Owner: Harsh007
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: wrap admin filter | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+------------------------------------

Changes (by Varun Kasyap Pentamaraju):

* cc: Varun Kasyap Pentamaraju (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:3>

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------------+------------------------------------
Reporter: Jacob Walls | Owner: Harsh007
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: wrap admin filter | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+------------------------------------

Changes (by Harsh007):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:4>

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------------+------------------------------------
Reporter: Jacob Walls | Owner: Harsh007
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: wrap admin filter | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-----------------------------------+------------------------------------

Comment (by Harsh007):

Hi, I’ve started looking into this ticket.

I can reproduce the issue on SQLite: using StringAgg(distinct=True) raises
an exception, even though SQLite’s native GROUP_CONCAT supports DISTINCT
in the form:

GROUP_CONCAT(DISTINCT expr)

This seems to be blocked because SQLite only allows DISTINCT when the
aggregate has a single argument (i.e., DISTINCT cannot be used when a
custom separator is passed).

A possible fix would be to allow StringAgg(distinct=True) on SQLite when
no explicit delimiter is provided, and add a regression test to cover the
supported DISTINCT behavior.

I’ll continue investigating the ORM aggregate SQL generation and will work
on a patch + tests.
--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:5>

[Django]

#36885: Long verbose names in the admin filter sidebar cause main area to reduce to
unusable width
-----------------------------------+------------------------------------
Reporter: Jacob Walls | Owner: Harsh007
Type: Bug | Status: assigned
Component: contrib.admin | Version: 5.2
Severity: Normal | Resolution:
Keywords: wrap admin filter | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 1
-----------------------------------+------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36885#comment:6>