[Django] #32884: Login header title is slightly off-center
Django
-----------------------------------------+------------------------
Reporter: louh | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-----------------------------------------+------------------------
On the `/admin/login` page, and on window sizes greater than 1024px wide,
the header that says "Django administration" is very slightly off-center.
This is caused by a 20px right margin on the `#branding h1` selector
(provided in `base.css`). See screenshots.
I don't think the solution is as simple as removing the margin, since the
style is used on other administration pages, but perhaps an override is
necessary (e.g. removing the right margin on the `.login #header h1`
selector, which is already declared).
I'm happy to provide a PR for review if needed. Thanks!
--
Ticket URL: <https://code.djangoproject.com/ticket/32884>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: louh | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by louh):
* Attachment "Screen Shot 2021-06-26 at 4.43.17 PM.png" added.
Django
Reporter: louh | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 3.2
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by louh):
* Attachment "Screen Shot 2021-06-26 at 4.49.52 PM.png" added.
Django
Reporter: Lou Huang | Owner: Lou Huang
Type: | Status: assigned
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* owner: nobody => Lou Huang
* status: new => assigned
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
Thanks for the report. Agreed, we can clear the margin on `.login #header
h1`.
> I'm happy to provide a PR for review if needed. Thanks!
Would be great, thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/32884#comment:1>
Django
Reporter: Lou Huang | Owner: Lou Huang
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Lou Huang):
* has_patch: 0 => 1
Comment:
Pull request created: https://github.com/django/django/pull/14567
--
Ticket URL: <https://code.djangoproject.com/ticket/32884#comment:2>
Django
Reporter: Lou Huang | Owner: Lou Huang
Type: | Status: assigned
Cleanup/optimization |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/32884#comment:3>
Django
Reporter: Lou Huang | Owner: Lou Huang
Cleanup/optimization |
Component: contrib.admin | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
Changes (by GitHub <noreply@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"7ba9da815dcccafd93fc44172d9f7f7019e8f2ed" 7ba9da8]:
{{{
#!CommitTicketReference repository=""
revision="7ba9da815dcccafd93fc44172d9f7f7019e8f2ed"
Fixed #32884 -- Fixed centering of the header on admin login page.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32884#comment:4>