[Django] #33930: Add id="deleted-objects" to template admin/delete_confirmation.html
Django
-------------------------------------+-------------------------------------
Reporter: Jacob | Owner: Jacob Rief
Rief |
Type: New | Status: assigned
feature |
Component: | Version: dev
contrib.admin | Keywords:
Severity: Normal | admin/delete_confirmation.html
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 1 |
-------------------------------------+-------------------------------------
As discussed on the developers mailing list, see
https://groups.google.com/g/django-developers/c/VTRqW7ZmB6A ,
is would make sense to add id="deleted-objects" to the <ul> element
showing the objects to be deleted.
Reason:
Whenever a user attempts to delete an object inside the Django admin,
a delete confirmation page is shown. If the object to be deleted contains
many relations, the user is overwhelmed with a list of other objects to be
deleted together with the current object. Often those objects are just
internal relations the user never heard of, and this may be unsettling.
By overriding that template one can use CSS to hide this list and add a
short
JavaScript snippet to unhide if necessary.
--
Ticket URL: <https://code.djangoproject.com/ticket/33930>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: | Rief
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
admin/delete_confirmation.html |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* type: New feature => Cleanup/optimization
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
Type: | Rief
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
admin/delete_confirmation.html |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* cc: אורי (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
Type: | Rief
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
admin/delete_confirmation.html |
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Comment (by Jacob Rief):
Pull request: https://github.com/django/django/pull/15967
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
Type: | Rief
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
admin/delete_confirmation.html |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
Type: | Rief
Cleanup/optimization | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
admin/delete_confirmation.html | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Jacob Rief | Owner: Jacob
Type: | Rief
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
admin/delete_confirmation.html | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"aed60aee38215e293d6ec2f3c96ec55bb9a62fc2" aed60ae]:
{{{
#!CommitTicketReference repository=""
revision="aed60aee38215e293d6ec2f3c96ec55bb9a62fc2"
Fixed #33930 -- Eased customization of delete_confirmation.html template
in the admin.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33930#comment:6>