[Django] #21183: Filter block on the right covers information in admin
Django
-------------------------------+--------------------
Reporter: Tuttle | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------+--------------------
Often, when the list_display has many columns or wide ones, the vertical
Filter block stays in the way...
I'd wish the blue header of right hand side Filter block in Admin to be
clickable to toggle the block visibility. jQuery-animated maybe.
IMHO, the collapse/expand state should be remembered between page loads.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Tuttle | Owner: nobody
Type: New feature | Status: new
Component: contrib.admin | Version: 1.5
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by EvilDMP):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:1>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Changes (by viciu):
* status: new => assigned
* owner: nobody => viciu
* version: 1.5 => master
* cc: wiktor@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:2>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 1
Comment (by viciu):
Pull request here: https://github.com/django/django/pull/2290/
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:3>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
collapse | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by viciu):
* keywords: => admin, filter, collapse
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:4>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
collapse | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
Changes (by oinopion):
* stage: Accepted => Ready for checkin
Comment:
I reviewed the PR and it look good.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:5>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
collapse | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by timo):
* needs_tests: 0 => 1
* stage: Ready for checkin => Accepted
Comment:
Selenium tests are required for a change like this.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:6>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, filter, | Triage Stage: Accepted
collapse | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 1 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Comment (by viciu):
Selenium tests added.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:7>
Django
Reporter: Tuttle | Owner: viciu
Type: New feature | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, filter, | Triage Stage: Accepted
collapse |
Easy pickings: 0 | UI/UX: 1
Changes (by timgraham):
* needs_better_patch: 0 => 1
* needs_tests: 1 => 0
Comment:
Patch needs improvement as per comments on PR.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:8>
Django
Reporter: Vlada Macek | Owner: (none)
Type: New feature | Status: new
Severity: Normal | Resolution:
Keywords: admin, filter, | Triage Stage: Accepted
collapse |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Changes (by Mariusz Felisiak):
* owner: Wiktor => (none)
* status: assigned => new
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:9>
Django
Reporter: Vlada Macek | Owner: (none)
Severity: Normal | Resolution:
Keywords: admin, filter, | Triage Stage: Accepted
collapse |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Comment (by Marcelo Galigniana):
Should this ticket be closed due ticket
https://code.djangoproject.com/ticket/27471 was merged?
I'm asking because of the
[https://code.djangoproject.com/ticket/27471#comment:5 Mariusz Felisiak's
comment]
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:10>
Django
Reporter: Vlada Macek | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: admin, filter, | Triage Stage:
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):
* status: new => closed
* needs_better_patch: 1 => 0
* has_patch: 1 => 0
* ui_ux: 1 => 0
* resolution: => wontfix
* stage: Accepted => Unreviewed
Comment:
Closing as "wontfix". #27471 has been implemented and we don't need both
options.
Marcelo, thanks for the reminder.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:11>
Django
Reporter: Vlada Macek | Owner: (none)
Severity: Normal | Resolution:
Keywords: admin, filter, | Triage Stage:
collapse | Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by rooterkyberian):
* status: closed => new
* resolution: wontfix =>
Comment:
As indicated in ticket description " Often, when the list_display has many
columns or wide ones, the vertical Filter block stays in the way..." .
The filter block internals being "collapsible"
(https://code.djangoproject.com/ticket/27471) does help with vertical
space, but does not help with the lack of horizontal space this ticket
about.
I want to reopen this issue, as I work at the company where this problem
affected multiple project and we wish to contribute to solve it upstream.
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:12>
Django
Reporter: Vlada Macek | Owner: (none)
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: admin, filter, | Triage Stage:
collapse | Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):
* status: new => closed
* resolution: => wontfix
Comment:
Hello Maciej, thank you for your interest in helping with Django!
Your contribution is welcomed! But, since this ticket was closed as
`wontfix` with a provided rationale, before re-opening the ticket, we
would need a new post in the Django Forum to explain the new rationale and
seek consensus to re-open.
To do that, please start a new conversation on the
[https://forum.djangoproject.com/c/internals/5 Django Forum], where you'll
reach a wider audience and likely get extra feedback. I'll close the
ticket for now (following the
[https://docs.djangoproject.com/en/4.2/internals/contributing/triaging-
tickets/#closing-tickets documented procedure]), but once that there is a
community agreement for the feature request, you are welcome to come back
to the ticket and point to the forum topic, so we can then re-open it. For
more details, please see
[https://docs.djangoproject.com/en/stable/internals/contributing/bugs-and-
features/#requesting-features the documented guidelines for requesting
features].
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:13>
Django
Reporter: Vlada Macek | Owner: (none)
Type: New feature | Status: closed
Component: contrib.admin | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: admin, filter, | Triage Stage:
collapse | Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Natalia Bidart):
On going forum discussion:
https://forum.djangoproject.com/t/ticket-21183-reopening/25269
--
Ticket URL: <https://code.djangoproject.com/ticket/21183#comment:14>