[Django] #23291: Putting Unicode var name and value in environment causes test suite errors on Windows/Python2

8 views
Skip to first unread message

Django

unread,
Aug 14, 2014, 11:02:08 AM8/14/14
to django-...@googlegroups.com
#23291: Putting Unicode var name and value in environment causes test suite errors
on Windows/Python2
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: new
Component: Core | Version: master
(Management commands) | Keywords:
Severity: Normal | Has patch: 1
Triage Stage: Accepted | Needs tests: 0
Needs documentation: 0 | Easy pickings: 0
Patch needs improvement: 0 |
UI/UX: 0 |
-------------------------------------+-------------------------------------
Running the `django_admin` tests on Windows shows errors like this one:

{{{
======================================================================
ERROR: test_noargs (admin_scripts.tests.CommandTypes)
NoArg Commands can be executed
----------------------------------------------------------------------
Traceback (most recent call last):
File "D:\django\upstream\tests\admin_scripts\tests.py", line 1498, in
test_noargs
out, err = self.run_manage(args)
File "D:\django\upstream\tests\admin_scripts\tests.py", line 180, in
run_manage
return self.run_test('./manage.py', args, settings_file)
File "D:\django\upstream\tests\admin_scripts\tests.py", line 149, in
run_test
env=test_environ, universal_newlines=True).communicate()
File "c:\Python27\lib\subprocess.py", line 679, in __init__
errread, errwrite)
File "c:\Python27\lib\subprocess.py", line 893, in _execute_child
startupinfo)
TypeError: environment can only contain strings
}}}

Total number of errors is 114.

Tested on a Windows 7 x86_64 system.

PR is at https://github.com/django/django/pull/3064

--
Ticket URL: <https://code.djangoproject.com/ticket/23291>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 14, 2014, 11:53:20 AM8/14/14
to django-...@googlegroups.com
#23291: Putting Unicode var name and value in environment causes test suite errors
on Windows/Python2
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: Core (Management | Version: master
commands) | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------
Changes (by ramiro):

* status: new => closed
* resolution: => fixed


Comment:

In 0bfb53866199f366ed140d49938fd185e5898156:

Fixed #23291 -- Don't add Unicode varname/value to environment.

--
Ticket URL: <https://code.djangoproject.com/ticket/23291#comment:1>

Django

unread,
Aug 14, 2014, 11:56:41 AM8/14/14
to django-...@googlegroups.com
#23291: Putting Unicode var name and value in environment causes test suite errors
on Windows/Python2
-------------------------------------+-------------------------------------
Reporter: ramiro | Owner: nobody
Type: Bug | Status: closed
Component: Core (Management | Version: master
commands) | Resolution: fixed
Severity: Normal | Triage Stage: Accepted
Keywords: | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 0
Needs tests: 0 | UI/UX: 0
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by Ramiro Morales <cramm0@…>):

In [changeset:"d9559fe163791be263bf8ea406fc287cbbfc9e45"]:
{{{
#!CommitTicketReference repository=""
revision="d9559fe163791be263bf8ea406fc287cbbfc9e45"
[1.7.x] Fixed #23291 -- Don't add Unicode varname/value to environment.

Windows doesn't like that and it causes 114 failures in the
admin_scripts tests with Python 2.x.

0bfb53866199f366ed140d49938fd185e5898156 from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23291#comment:2>

Reply all
Reply to author
Forward
0 new messages