[Django] #25149: Replace window.__admin_utc_offset__ with a data attribute

[Django]

#25149: Replace window.__admin_utc_offset__ with a data attribute
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: | Status: new
Cleanup/optimization |
Component: | Version: 1.8
contrib.admin |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
I don't think storing global variables on `window` is a best practice
these days.

--
Ticket URL: <https://code.djangoproject.com/ticket/25149>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#25149: Replace window.__admin_utc_offset__ with a data attribute
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: | Status: new
Cleanup/optimization |

Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by timgraham):

* has_patch: 0 => 1

Comment:

[https://github.com/django/django/pull/5027 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/25149#comment:1>

[Django]

#25149: Replace window.__admin_utc_offset__ with a data attribute
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham
Type: | Status: new
Cleanup/optimization |

Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by aaugustin):

* stage: Unreviewed => Accepted

--
Ticket URL: <https://code.djangoproject.com/ticket/25149#comment:2>

[Django]

#25149: Replace window.__admin_utc_offset__ with a data attribute
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham

Type: | Status: closed

Cleanup/optimization |
Component: contrib.admin | Version: 1.8

Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"8eeb566aca33600d272dee5fba59c3445b5b8163" 8eeb566a]:
{{{
#!CommitTicketReference repository=""
revision="8eeb566aca33600d272dee5fba59c3445b5b8163"
Fixed #25149 -- Replaced window.__admin_utc_offset__ with a data
attribute.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25149#comment:3>

[Django]

#25149: Replace window.__admin_utc_offset__ with a data attribute
-------------------------------------+-------------------------------------
Reporter: timgraham | Owner: timgraham

Type: | Status: closed
Cleanup/optimization |
Component: contrib.admin | Version: 1.8
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"0603f09318049e67320121ace035b7ab03f88ca3" 0603f093]:
{{{
#!CommitTicketReference repository=""
revision="0603f09318049e67320121ace035b7ab03f88ca3"
Refs #25149 -- Fixed regression in admin datetime widget for timezones on
the negative side of UTC.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/25149#comment:4>