[Django] #23923: Promote Django's deprecation warnings to errors in runtests.py

9 views
Skip to first unread message

Django

unread,
Nov 26, 2014, 4:21:18 PM11/26/14
to django-...@googlegroups.com
#23923: Promote Django's deprecation warnings to errors in runtests.py
------------------------------------------------+------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The Django test suite should run without any visible deprecation warnings.

By changing:
{{{
warnings.simplefilter("default", RemovedInDjango19Warning)
warnings.simplefilter("default", RemovedInDjango20Warning)
}}}
to:
{{{
warnings.simplefilter("error", RemovedInDjango19Warning)
warnings.simplefilter("error", RemovedInDjango20Warning)
}}}
in `runtests.py` we can have Jenkins (which runs with -Wall) fail builds
that introduce unsilenced deprecation warnings. This will save us time
from having to track them down after the fact.

--
Ticket URL: <https://code.djangoproject.com/ticket/23923>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 26, 2014, 4:33:04 PM11/26/14
to django-...@googlegroups.com
#23923: Promote Django's deprecation warnings to errors in runtests.py
--------------------------------------+------------------------------------

Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by charettes):

* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/23923#comment:1>

Django

unread,
Nov 28, 2014, 8:43:12 PM11/28/14
to django-...@googlegroups.com
#23923: Promote Django's deprecation warnings to errors in runtests.py
--------------------------------------+------------------------------------

Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timgraham):

* has_patch: 0 => 1


Comment:

[https://github.com/django/django/pull/3626 PR] is ready for review.

--
Ticket URL: <https://code.djangoproject.com/ticket/23923#comment:2>

Django

unread,
Nov 29, 2014, 10:27:33 AM11/29/14
to django-...@googlegroups.com
#23923: Promote Django's deprecation warnings to errors in runtests.py
--------------------------------------+------------------------------------
Reporter: timgraham | Owner: nobody
Type: Cleanup/optimization | Status: closed

Component: Testing framework | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"3131e9cef5f0a96f4fe667b0b1626c238153d1f1"]:
{{{
#!CommitTicketReference repository=""
revision="3131e9cef5f0a96f4fe667b0b1626c238153d1f1"
Fixed #23923 -- Promoted Django's deprecation warnings to errors in
runtests.py
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23923#comment:3>

Reply all
Reply to author
Forward
0 new messages