[Django] #33805: SelectMultiple in ModelAdminForm help_text render

20 views
Skip to first unread message

Django

unread,
Jun 24, 2022, 4:11:24 AM6/24/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm help_text render
-------------------------------------+-------------------------------------
Reporter: Maxim | Owner: nobody
Danilov |
Type: Bug | Status: new
Component: | Version: 4.1
contrib.admin | Keywords: modeladmin,
Severity: Normal | AdminForm
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 1
UI/UX: 0 |
-------------------------------------+-------------------------------------
In AdminForm Help text on render for SelectMultiple widget don't check, if
widget.allow_multiple_selected = False.

Widget himself on render checks it

{{{
# django.forms.widgets rows 684-685
if self.allow_multiple_selected:
context['widget']['attrs']['multiple'] = True
}}}

But help_text for widget, whose is rendered behind widget - don't checks
it. There we check only "isinstance"

{{{
# django.contrib.admin.options.py rows 280-281
if (isinstance(form_field.widget, SelectMultiple) ann not
isinstance(form_field.widget, (CheckboxSelectMultiple,
AutocompleteSelectMultiple))):
... # do some stuff with help text
}}}

as a result I get "msg", which should not be.

--
Ticket URL: <https://code.djangoproject.com/ticket/33805>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 24, 2022, 4:12:17 AM6/24/22
to django-...@googlegroups.com
#33805: SelectMultiple in ModelAdminForm help_text render
-------------------------------------+-------------------------------------
Reporter: Maxim Danilov | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 4.1
Severity: Normal | Resolution:
Keywords: modeladmin, | Triage Stage:
AdminForm | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Maxim Danilov):

* Attachment "Unbenannt.png" added.

rendered m2m field with allow_multiple_selected=False

Reply all
Reply to author
Forward
0 new messages