[Django] #35837: Missing alters_data=True on QuerySet and UserManager

[Django]

#35837: Missing alters_data=True on QuerySet and UserManager
-------------------------------------+-------------------------------------
Reporter: Sarah | Owner: Sarah Boyce
Boyce |
Type: | Status: assigned
Uncategorized |
Component: Database | Version: dev
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
`alters_data=True` is missing on (and their async equivalents)

* `UserManager.create_user`
* `UserManager.create_superuser`
* `QuerySet.create`
* `QuerySet.bulk_create`
* `QuerySet.get_or_create`
* `QuerySet.update_or_create`
--
Ticket URL: <https://code.djangoproject.com/ticket/35837>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35837: Missing alters_data=True on QuerySet and UserManager
-------------------------------------+-------------------------------------

Reporter: Sarah Boyce | Owner: Sarah
| Boyce
Type: Uncategorized | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35837#comment:1>

[Django]

#35837: Missing alters_data=True on QuerySet and UserManager
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Sarah
| Boyce

Type: Bug | Status: assigned

Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: alters_data | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* cc: Shai Berger (added)
* keywords: => alters_data
* stage: Unreviewed => Accepted
* type: Uncategorized => Bug

Comment:

Thank you Sarah! This makes sense and matches internal conversations held
within the Security Team.
--
Ticket URL: <https://code.djangoproject.com/ticket/35837#comment:2>

[Django]

#35837: Missing alters_data=True on QuerySet and UserManager
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Sarah
| Boyce
Type: Bug | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:

Keywords: alters_data | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/35837#comment:3>

[Django]

#35837: Missing alters_data=True on QuerySet and UserManager
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: Sarah
| Boyce

Type: Bug | Status: closed

Component: Database layer | Version: dev
(models, ORM) |

Severity: Normal | Resolution: fixed

Keywords: alters_data | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce <42296566+sarahboyce@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"611bf6c2e2a1b4ab93273980c45150c099ab146d" 611bf6c]:
{{{#!CommitTicketReference repository=""
revision="611bf6c2e2a1b4ab93273980c45150c099ab146d"
Fixed #35837 -- Added missing alters_data=True to QuerySet and UserManager
methods.

Thank you to Jason Chambers for the report and to Mariusz Felisiak for the
review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35837#comment:4>