[Django] #36230: Better color contrast for blockquote in admin docs

Django

unread,

Mar 4, 2025, 4:59:43 PM3/4/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana | Owner: Eliana Rosselli
Rosselli |
Type: | Status: assigned
Uncategorized |
Component: | Version: 5.1
Uncategorized | Keywords: accessibility
Severity: Normal | colors contrast
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
In the Admin Docs, the color contrast for text in blockquotes is quite
low, making the text very hard to read. An example can be seen in the
[https://thibaudcolas.github.io/django_admin_tests/latest/english/admin/doc/tags/
template tags docs].

[[Image(blockquote-example.png)]]

The blockquote color is hard-coded to a shade of gray that isn’t visible
in the dark theme. It needs switching to an existing CSS variable so the
color contrast is good enough in both themes.
--
Ticket URL: <https://code.djangoproject.com/ticket/36230>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Mar 4, 2025, 5:00:49 PM3/4/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Eliana Rosselli):

* Attachment "blockquote-example.png" added.

Example from Django Admin Docs of a blockquote with poor color contrast on
dark mode

Django

unread,

Mar 4, 2025, 5:01:42 PM3/4/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli

Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1

Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage:
colors contrast | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Eliana Rosselli):

* component: Uncategorized => contrib.admindocs
* type: Uncategorized => Bug

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:1>

Django

unread,

Mar 5, 2025, 4:05:56 AM3/5/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage:
colors contrast | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* Attachment "image-20250305-100550.png" added.

--
Ticket URL: <https://code.djangoproject.com/ticket/36230>

Django

unread,

Mar 5, 2025, 4:07:01 AM3/5/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Accepted
colors contrast |

Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

* stage: Unreviewed => Accepted

Comment:

Agreed the contrast can be improved, thank you for the ticket
[[Image(image-20250305-100550.png)]]
--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:2>

Django

unread,

Mar 13, 2025, 9:08:29 AM3/13/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------

Reporter: Eliana Rosselli | Owner: Jordan

Changes (by Jordan):

* owner: Eliana Rosselli => Jordan

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:3>

Django

unread,

Mar 13, 2025, 9:22:28 AM3/13/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Jordan
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
colors contrast |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jordan):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:4>

Django

unread,

Mar 13, 2025, 10:26:16 AM3/13/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Jordan
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
colors contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jordan):

Pull request available at: https://github.com/django/django/pull/19268
--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:5>

Django

unread,

Mar 13, 2025, 11:44:49 AM3/13/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------

Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli

Changes (by Sarah Boyce):

* owner: Jordan => Eliana Rosselli

Comment:

Thank you Jordan, however, this ticket was recently created and assigned
to Eliana. That's because she is working on it (and helping her mentees
currently)
Please do not work on tickets that are recently assigned to other folks,
if it has been over a month, then perhaps ask if they are working on it
still. Over 6 months, then I'd say it's safe to assume it's not being
worked on.
--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:6>

Django

unread,

Mar 13, 2025, 3:35:59 PM3/13/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
colors contrast |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Jordan):

My apologies, this was my first time ever contributing to open source. I
will make sure to find tickets that have not been assigned in the future!
Replying to [comment:6 Sarah Boyce]:

> Thank you Jordan, however, this ticket was recently created and assigned
to Eliana. That's because she is working on it (and helping her mentees
currently)
> Please do not work on tickets that are recently assigned to other folks,
if it has been over a month, then perhaps ask if they are working on it
still. Over 6 months, then I'd say it's safe to assume it's not being
worked on.
--

Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:7>

Django

unread,

Mar 26, 2025, 10:42:29 AM3/26/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner: Eliana
| Rosselli
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:
Keywords: accessibility | Triage Stage: Accepted
colors contrast |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:8>

Django

unread,

Mar 27, 2025, 3:41:18 AM3/27/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------

Reporter: Eliana Rosselli | Owner: Jordan

* owner: Eliana Rosselli => Jordan

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:9>

Django

unread,

Jul 20, 2025, 8:22:25 AM7/20/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner:

| LauHerregodts

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* needs_better_patch: 1 => 0
* owner: Jordan => LauHerregodts
* ui_ux: 0 => 1

Comment:

I see this hasn’t had activity in a while so I’ve encouraged
@LauHerregodts to take this on at the EuroPython sprints.
[https://github.com/django/django/pull/19656 Fixed #36230 -- Improve
blockquote contrast #19656].
--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:10>

Django

unread,

Jul 20, 2025, 8:43:18 AM7/20/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner:
| LauHerregodts
Type: Bug | Status: assigned
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution:

Keywords: accessibility | Triage Stage: Ready for
colors contrast | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Thibaud Colas):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:11>

Django

unread,

Jul 20, 2025, 3:12:57 PM7/20/25

to django-...@googlegroups.com

#36230: Better color contrast for blockquote in admin docs
-------------------------------------+-------------------------------------
Reporter: Eliana Rosselli | Owner:
| LauHerregodts

Type: Bug | Status: closed
Component: contrib.admindocs | Version: 5.1
Severity: Normal | Resolution: fixed

Keywords: accessibility | Triage Stage: Ready for
colors contrast | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by GitHub <noreply@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"896fa85b0217ebc3a13c6ea42688f160103d0962" 896fa85]:
{{{#!CommitTicketReference repository=""
revision="896fa85b0217ebc3a13c6ea42688f160103d0962"
Fixed #36230 -- Improved color contrast for blockquote in admin.

Thanks Thibaud Colas for the review.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36230#comment:12>

Reply all

Reply to author

Forward