Re: [Django] #12890: extra() tables included twice do not generate aliases
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.1 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 0
Patch needs improvement: 0 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by anonymous):
* easy: => 0
Comment:
I'm still waiting to hear back on this patch...would the core contributors
respond more quickly to a 1.3 patch? I'd just like some word on whether
this will be rolled into the core or not. Thanks.
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Resolution: | Severity: Normal
Triage Stage: | Keywords:
Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by daveycrockett):
* has_patch: 0 => 1
* version: 1.1 => 1.2
* stage: Accepted => Unreviewed
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.2 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: | Keywords:
Unreviewed | Has patch: 1
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by daveycrockett):
* cc: daveycrockett (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.2 | (models, ORM)
Resolution: | Severity: Normal
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 0 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by russellm):
* stage: Unreviewed => Accepted
Comment:
Reverting stage change. Ticket has already been accepted. The Unreviewed
state refers to that triage status of the ticket, not the review status of
an individual patch.
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:9>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.2 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 0 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Comment (by daveycrockett):
Thank you for the insight on the django ticketing process?
I now understand that the ticket itself has been "reviewed" and "accepted"
as a legitimate bug. My next question would be when will the patch be
"reviewed"?
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:10>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: nobody
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.2 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by lukeplant):
* needs_better_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
Replying to [comment:10 daveycrockett]:
> I now understand that the ticket itself has been "reviewed" and
"accepted" as a legitimate bug. My next question would be when will the
patch be "reviewed"?
Reviewing is done by the community, and we can't make guarantees about
that I'm afraid. Please see
https://docs.djangoproject.com/en/dev/internals/contributing/ or ask on
django-devs for other questions about this process.
However, I can tell you right now that the patch needs some work,
particularly because it has no tests, and will not get in without them.
That would help in reviewing. It also needs to be in unified diff format -
you have to manually edit it just to even attempt to apply it without
that. It must apply to trunk as well - I've no idea if it does or not.
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:11>
Django
-------------------------------------+-------------------------------------
Milestone: | Component: Database layer
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 1
-------------------------------------+-------------------------------------
Changes (by daveycrockett):
* owner: nobody => daveycrockett
* ui_ux: => 0
* version: 1.2 => 1.3
Comment:
This bug also manifests in 1.3, supplied patches for both 1.2.5 and 1.3
with tests!
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:12>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: daveycrockett
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.3 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
* has_patch: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:13>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: daveycrockett
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.3 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
-------------------------------------+-------------------------------------
Changes (by anonymous):
* needs_better_patch: 1 => 0
* has_patch: 0 => 1
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:14>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner: daveycrockett
Type: Bug | Status: new
Milestone: | Component: Database layer
Version: 1.3 | (models, ORM)
Resolution: | Severity: Normal
Triage Stage: Accepted | Keywords:
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 0 | Needs tests: 1
UI/UX: 0 | Easy pickings: 0
-------------------------------------+-------------------------------------
* cc: michael@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:15>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner:
Component: Database layer | Status: new
(models, ORM) | Version: 1.3
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by akaariai):
The proposed patch will cause backwards incompatibilities.
I think the way to implement this is to have explicit alias syntax,
something like .extra(tables=[('queries_nestednode', 'T1')]). I am not too
happy to add more .extra() features as it would be better to replace the
whole thing with something better. But it has been some time and that
something better isn't implemented yet, so a little patch to .extra()
could be accepted.
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:16>
Django
-------------------------------------+-------------------------------------
Reporter: semenov | Owner:
Type: Bug | Status: closed
Component: Database layer | Version: 1.3
(models, ORM) |
Keywords: QuerySet.extra | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* keywords: => QuerySet.extra
* status: new => closed
* resolution: => wontfix
Comment:
We are no longer fixing bugs with `QuerySet.extra()` per
[https://groups.google.com/d/topic/django-
developers/FojuU0syO8Y/discussion discussion on django-developers].
--
Ticket URL: <https://code.djangoproject.com/ticket/12890#comment:17>