[Django] #28635: Non-ASCII url prefix

[Django]

#28635: Non-ASCII url prefix
-------------------------------------+-------------------------------------
Reporter: Wenli | Owner: nobody
Tsai |
Type: Bug | Status: new
Component: | Version: 1.11
contrib.admin | Keywords:
Severity: Normal | add_preserved_filters
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
We found the preserved_filters won't be correctly recovered when url
contains non-ASCII prefix.

When save the change form and return to the changelist,
the changelist url should be `/admin/myApp/台灣Model/?cityID=a`.

But we got `/admin/myApp/台灣Model/?_changelist_filters=cityID%3Da`, and
302 redirected to `/admin/myApp/台灣Model/?e=1`.

--
Ticket URL: <https://code.djangoproject.com/ticket/28635>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#28635: Non-ASCII url prefix
-------------------------------------+-------------------------------------

Reporter: Wenli Tsai | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
add_preserved_filters | Unreviewed
Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Wenli Tsai:

Old description:

> We found the preserved_filters won't be correctly recovered when url
> contains non-ASCII prefix.
>
> When save the change form and return to the changelist,
> the changelist url should be `/admin/myApp/台灣Model/?cityID=a`.
>
> But we got `/admin/myApp/台灣Model/?_changelist_filters=cityID%3Da`, and
> 302 redirected to `/admin/myApp/台灣Model/?e=1`.

New description:

The preserved_filters won't be correctly recovered when url contains non-
ASCII prefix.

When save the change form and return to the changelist,
the changelist url should be `/admin/myApp/台灣Model/?cityID=a`.

But we got `/admin/myApp/台灣Model/?_changelist_filters=cityID%3Da`,
and 302 redirected to `/admin/myApp/台灣Model/?e=1`.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:1>

[Django]

#28635: Preserved filters with non-ASCII url prefix
-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
add_preserved_filters | Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:2>

[Django]

#28635: Preserved filters with unicode url prefix
-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
add_preserved_filters | Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:3>

[Django]

#28635: Preserved filters with unicode url prefix
-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage:
add_preserved_filters | Unreviewed

Has patch: 0 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Description changed by Wenli Tsai:

Old description:

> The preserved_filters won't be correctly recovered when url contains non-

> ASCII prefix.
>
> When save the change form and return to the changelist,
> the changelist url should be `/admin/myApp/台灣Model/?cityID=a`.
>
> But we got `/admin/myApp/台灣Model/?_changelist_filters=cityID%3Da`,
> and 302 redirected to `/admin/myApp/台灣Model/?e=1`.

New description:

The preserved_filters won't be correctly recovered when url contains
unicode prefix.

When save the change form and return to the changelist,
the changelist url should be `/admin/myApp/台灣Model/?cityID=a`.

But we got `/admin/myApp/台灣Model/?_changelist_filters=cityID%3Da`,
and 302 redirected to `/admin/myApp/台灣Model/?e=1`.

--

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:4>

[Django]

#28635: admin's preserved filters don't work if the URL has non-ASCII characters in
it

-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner: nobody

Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage: Accepted
add_preserved_filters |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham):

* has_patch: 0 => 1
* stage: Unreviewed => Accepted

Comment:

[https://github.com/django/django/pull/9145 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:5>

[Django]

#28635: admin's preserved filters don't work if the URL has non-ASCII characters in
it
-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner:

| Dheerendra Rathor
Type: Bug | Status: assigned

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
add_preserved_filters |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Dheerendra Rathor):

* owner: nobody => Dheerendra Rathor
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:6>

[Django]

#28635: admin's preserved filters don't work if the URL has non-ASCII characters in
it
-------------------------------------+-------------------------------------

Reporter: Wenli Tsai | Owner: (none)
Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
add_preserved_filters |

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Dheerendra Rathor):

* owner: Dheerendra Rathor => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:7>

[Django]

#28635: admin's preserved filters don't work if the URL has non-ASCII characters in
it
-------------------------------------+-------------------------------------

Reporter: Wenli Tsai | Owner: nobody
Type: Bug | Status: new

Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution:

Keywords: | Triage Stage: Ready for
add_preserved_filters | checkin
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Carlton Gibson):

* stage: Accepted => Ready for checkin

Comment:

PR looks good.

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:6>

[Django]

#28635: admin's preserved filters don't work if the URL has non-ASCII characters in
it
-------------------------------------+-------------------------------------
Reporter: Wenli Tsai | Owner: nobody

Type: Bug | Status: closed
Component: contrib.admin | Version: 1.11
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
add_preserved_filters | checkin

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed

Comment:

In [changeset:"ba37ee9ef882deb8e917f1cae0c586a0a275e731" ba37ee9e]:
{{{
#!CommitTicketReference repository=""
revision="ba37ee9ef882deb8e917f1cae0c586a0a275e731"
Fixed #28635 -- Fixed admin's preserved filters if the URL contains non-
ASCII characters.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/28635#comment:7>