[Django] #27532: Remove Model._meta.has_auto_field

12 views
Skip to first unread message

Django

unread,
Nov 24, 2016, 6:26:21 PM11/24/16
to django-...@googlegroups.com
#27532: Remove Model._meta.has_auto_field
-------------------------------------+-------------------------------------
Reporter: Adam | Owner: nobody
Chainz |
Type: | Status: assigned
Cleanup/optimization |
Component: Database | Version: 1.10
layer (models, ORM) |
Severity: Normal | Keywords:
Triage Stage: | Has patch: 0
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
It seems a bit of a waste when it just mirrors the result of
`bool(Model._meta.auto_field)`, and it's not used in many places.

--
Ticket URL: <https://code.djangoproject.com/ticket/27532>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Nov 24, 2016, 6:35:54 PM11/24/16
to django-...@googlegroups.com
#27532: Remove Model._meta.has_auto_field
-------------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: Adam
Type: | Chainz
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Adam Chainz):

* cc: me@… (added)
* owner: nobody => Adam Chainz
* has_patch: 0 => 1


Comment:

[PR](https://github.com/django/django/pull/7603)

--
Ticket URL: <https://code.djangoproject.com/ticket/27532#comment:1>

Django

unread,
Nov 25, 2016, 8:05:54 AM11/25/16
to django-...@googlegroups.com
#27532: Deprecate Model._meta.has_auto_field

-------------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: Adam
Type: | Chainz
Cleanup/optimization | Status: assigned
Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham):

* needs_better_patch: 0 => 1
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/27532#comment:2>

Django

unread,
Nov 25, 2016, 1:24:59 PM11/25/16
to django-...@googlegroups.com
#27532: Deprecate Model._meta.has_auto_field
-------------------------------------+-------------------------------------
Reporter: Adam Chainz | Owner: Adam
Type: | Chainz
Cleanup/optimization | Status: closed

Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"6252fd6314f66d2d303cc47c791ffefd27169b42" 6252fd63]:
{{{
#!CommitTicketReference repository=""
revision="6252fd6314f66d2d303cc47c791ffefd27169b42"
Fixed #27532 -- Deprecated Model._meta.has_auto_field
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27532#comment:3>

Django

unread,
Sep 22, 2017, 1:39:42 PM9/22/17
to django-...@googlegroups.com
#27532: Deprecate Model._meta.has_auto_field
-------------------------------------+-------------------------------------
Reporter: Adam (Chainz) | Owner: Adam
Johnson | (Chainz) Johnson
Type: | Status: closed
Cleanup/optimization |

Component: Database layer | Version: 1.10
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"5bcca2a056f56b75e6a21670b32b982ef98f422a" 5bcca2a]:
{{{
#!CommitTicketReference repository=""
revision="5bcca2a056f56b75e6a21670b32b982ef98f422a"
Refs #27532 -- Removed Model._meta.has_auto_field per deprecation
timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/27532#comment:4>

Reply all
Reply to author
Forward
0 new messages