[Django] #33201: RenameModel with db_table recreate constraints.
Django
------------------------------------------+------------------------
Reporter: Iuri de Silvio | Owner: nobody
Type: Bug | Status: new
Component: Migrations | Version: 3.2
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------+------------------------
A RenameModel operation that already has db_table defined must be a noop.
In Postgres, it drops and recreates foreign key constraints. In sqlite it
recreates the table (as expected for a table renaming).
--
Ticket URL: <https://code.djangoproject.com/ticket/33201>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: Iuri de Silvio | Owner: Iuri de Silvio
Type: Bug | Status: assigned
Component: Migrations | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Iuri de Silvio):
* owner: nobody => Iuri de Silvio
* status: new => assigned
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Component: Migrations | Version: 3.2
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* has_patch: 0 => 1
* type: Bug => Cleanup/optimization
* stage: Unreviewed => Accepted
Comment:
[https://github.com/django/django/pull/14999 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Iuri de Silvio):
I fixed the patch and it is waiting for review.
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Component: Migrations | Version: 3.2
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"afeafd6036616bac8263d762c1610f22241c0187" afeafd60]:
{{{
#!CommitTicketReference repository=""
revision="afeafd6036616bac8263d762c1610f22241c0187"
Fixed #33201 -- Made RenameModel operation a noop for models with
db_table.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"166a3b32632c141541d1c3f0eff18e1d8b389404" 166a3b32]:
{{{
#!CommitTicketReference repository=""
revision="166a3b32632c141541d1c3f0eff18e1d8b389404"
Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel operation a
noop for models with db_table."
Regression in afeafd6036616bac8263d762c1610f22241c0187.
This reverts afeafd6036616bac8263d762c1610f22241c0187.
Thanks Timothy Thomas for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:6>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Mariusz Felisiak <felisiak.mariusz@…>):
In [changeset:"7d5ccbbe1a3ad99b02c25f1ce90f36334d881ab6" 7d5ccbbe]:
{{{
#!CommitTicketReference repository=""
revision="7d5ccbbe1a3ad99b02c25f1ce90f36334d881ab6"
[4.1.x] Fixed #33953 -- Reverted "Fixed #33201 -- Made RenameModel
operation a noop for models with db_table."
Regression in afeafd6036616bac8263d762c1610f22241c0187.
This reverts afeafd6036616bac8263d762c1610f22241c0187.
Thanks Timothy Thomas for the report.
Backport of 166a3b32632c141541d1c3f0eff18e1d8b389404 from main
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:7>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Mariusz Felisiak):
* has_patch: 1 => 0
* resolution: fixed => wontfix
* stage: Ready for checkin => Unreviewed
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:8>
Django
-------------------------------------+-------------------------------------
Reporter: Iuri de Silvio | Owner: Iuri de
Type: | Silvio
Cleanup/optimization | Status: closed
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Comment (by GitHub <noreply@…>):
In [changeset:"3109038992321e471944bd8ee36670c9e6b8ff0c" 31090389]:
{{{
#!CommitTicketReference repository=""
revision="3109038992321e471944bd8ee36670c9e6b8ff0c"
Refs #33201 -- Avoided unnecessary queries when renaming models with
db_table on SpatiaLite.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33201#comment:9>