[Django] #33862: Workflow to run the Django benchmarks when a pull request is labeled
Django
-------------------------------------+-------------------------------------
Reporter: Deepak | Owner: nobody
Dinesh |
Type: | Status: assigned
Uncategorized |
Component: | Version: dev
Uncategorized | Keywords: Workflow, GitHub
Severity: Normal | actions
Triage Stage: | Has patch: 1
Unreviewed |
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
-------------------------------------+-------------------------------------
One of the goals of the GSoC 22 Django benchmarking project was to provide
a way for devs to run the benchmarks against their PR's to see the effect
on the performance due to the changes made so that it can be improved
before merging.
I have added a workflow that runs the benchmarks in
[https://github.com/smithdc1/django-asv smithdc1/django-asv] against a
pull request when it is labeled with the label '''benchmark'''. If the
performance has not changed significantly, a pull request status message
''' Benchmarking Result - BENCHMARKS NOT CHANGED SIGNIFICANTLY''' is
added, if the performance has decreased a pull request status message '''
Benchmarking Result - SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY.
PERFORMANCE DECREASED ''' is added.
The workflow only gets triggered when the PR's which are made after the
workflow has been added are labeled.
--
Ticket URL: <https://code.djangoproject.com/ticket/33862>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
-------------------------------------+-------------------------------------
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: Workflow, GitHub | Triage Stage: Accepted
actions |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* cc: David Smith (added)
* type: Uncategorized => New feature
* component: Uncategorized => Testing framework
* stage: Unreviewed => Accepted
Comment:
Hey Deepak — Thanks.
Let's accept this. I'm not 100% clear immediately on the relation between
the workflows across repos — but I'm guessing it's easier to see in code:
if you open a PR on django/django for what needs adding, that would be
great.
Maybe a scheduled trigger every X days (or every Monday, for example)
would be useful too. 🤔
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:1>
Django
-------------------------------------+-------------------------------------
Reporter: Deepak Dinesh | Owner: nobody
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: Workflow, GitHub | Triage Stage: Accepted
actions |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Deepak Dinesh):
A scheduled trigger has been added to smitdc1/django-asv, it currently
runs once every day but I will change it to every Monday at a later stage.
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:2>
Django
-------------------------------------+-------------------------------------
Reporter: Deepak Dinesh | Owner: nobody
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: Workflow, GitHub | Triage Stage: Accepted
actions |
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 0 => 1
* needs_docs: 0 => 1
Comment:
Hey Deepak I'm going to mark this needing improvement*, whilst we resolve
the details about the repo-interactions.
I'm looking at that now — will comment on the ASV repo.
*: And docs: we'll need to tell folks at least that the ASV project
exists, and how to mark a PR for benchmarking (in the wiki at least, if
not the contributing guide.)
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:3>
Django
-------------------------------------+-------------------------------------
| Dinesh
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
Keywords: Workflow, GitHub | Triage Stage: Accepted
actions |
Has patch: 1 | Needs documentation: 1
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* owner: nobody => Deepak Dinesh
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: Deepak Dinesh | Owner: Deepak
| Dinesh
Type: New feature | Status: assigned
Component: Testing framework | Version: dev
Severity: Normal | Resolution:
actions | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
* needs_docs: 1 => 0
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: Deepak Dinesh | Owner: Deepak
| Dinesh
Component: Testing framework | Version: dev
Keywords: Workflow, GitHub | Triage Stage: Ready for
actions | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"982a970251bf2255a5fb587d3e953a2fcd563107" 982a9702]:
{{{
#!CommitTicketReference repository=""
revision="982a970251bf2255a5fb587d3e953a2fcd563107"
Fixed #33862 -- Added workflow to run the ASV benchmarks for labeled PR.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/33862#comment:6>