[Django] #33924: Deprecate BaseGeometryWidget.map_height / .map_width

11 views
Skip to first unread message

Django

unread,
Aug 12, 2022, 6:21:56 AM8/12/22
to django-...@googlegroups.com
#33924: Deprecate BaseGeometryWidget.map_height / .map_width
------------------------------------------------+------------------------
Reporter: Claude Paroz | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: GIS | Version: dev
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The map widget size should be set through CSS, presentation properties do
not belong to widget code.

--
Ticket URL: <https://code.djangoproject.com/ticket/33924>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Aug 12, 2022, 6:30:10 AM8/12/22
to django-...@googlegroups.com
#33924: Deprecate BaseGeometryWidget.map_height / .map_width
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* owner: nobody => Claude Paroz
* status: new => assigned
* has_patch: 0 => 1
* stage: Unreviewed => Accepted


Comment:

[https://github.com/django/django/pull/15953 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/33924#comment:1>

Django

unread,
Aug 12, 2022, 7:27:28 AM8/12/22
to django-...@googlegroups.com
#33924: Deprecate BaseGeometryWidget.map_height / .map_width
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/33924#comment:2>

Django

unread,
Aug 12, 2022, 7:55:30 AM8/12/22
to django-...@googlegroups.com
#33924: Deprecate BaseGeometryWidget.map_height / .map_width
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed

Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak <felisiak.mariusz@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"4fcba800b84fc5fb53cdc70e4bea37ec958516fd" 4fcba800]:
{{{
#!CommitTicketReference repository=""
revision="4fcba800b84fc5fb53cdc70e4bea37ec958516fd"
Fixed #33924 -- Deprecated BaseGeometryWidget.map_height/map_width
attributes.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33924#comment:3>

Django

unread,
Sep 18, 2023, 4:12:52 PM9/18/23
to django-...@googlegroups.com
#33924: Deprecate BaseGeometryWidget.map_height / .map_width
-------------------------------------+-------------------------------------
Reporter: Claude Paroz | Owner: Claude
Type: | Paroz
Cleanup/optimization | Status: closed
Component: GIS | Version: dev
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak <felisiak.mariusz@…>):

In [changeset:"7433237664e9a942d6584b4e70fd6a5174cf8f39" 7433237]:
{{{
#!CommitTicketReference repository=""
revision="7433237664e9a942d6584b4e70fd6a5174cf8f39"
Refs #33924 -- Removed BaseGeometryWidget.map_height/map_width attributes
per deprecation timeline.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/33924#comment:4>

Reply all
Reply to author
Forward
0 new messages