[Django] #22038: Admin shows selected rows as "<amount> of undefined selected"
Django
-------------------------------+--------------------
Reporter: bpeschier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 1
Easy pickings: 0 | UI/UX: 0
-------------------------------+--------------------
Commit
https://github.com/django/django/commit/4523fcd60101124a307bd4026296337087b66884
introduces ```_actions_icnt``` to the local scope, which overrides the
value set in the HTML.
The admin will show selected rows in a change list as "1 of undefined
selected".
PR under https://github.com/django/django/pull/2274; looking into a test.
--
Ticket URL: <https://code.djangoproject.com/ticket/22038>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: bpeschier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by bmispelon):
* needs_docs: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 1
* needs_better_patch: => 1
Comment:
Hi,
Th PR looks good but it'd be better with some tests.
I was also thinking it might be wise to add a comment on the line where
`_actions_icnt` is used to indicate that the lack of declaration is on
purpose.
I'll mark this as `release blocker` as well so that it doesn't slip
through the cracks.
Thanks for catching this.
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:1>
Django
Reporter: bpeschier | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by claudep):
Tim merged the PR in 83a3add4bed8d8d49f93b30c817c66908b0a26ba. A test
would be nice.
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:2>
Django
Reporter: bpeschier | Owner: bpeschier
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: nlsprint14 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bpeschier):
* owner: nobody => bpeschier
* status: new => assigned
* keywords: => nlsprint14
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:3>
Django
Reporter: bpeschier | Owner: bpeschier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: nlsprint14 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by bmispelon):
the modified js file should also be minified:
https://docs.djangoproject.com/en/1.6/internals/contributing/writing-code
/submitting-patches/#compressing-javascript
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:4>
Django
Reporter: bpeschier | Owner: bpeschier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: nlsprint14 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by bpeschier):
Sent a new PR which documents the variable, adds a test and minifies the
Javascript: https://github.com/django/django/pull/2340
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:5>
Django
Reporter: bpeschier | Owner: bpeschier
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: nlsprint14 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Baptiste Mispelon <bmispelon@…>):
In [changeset:"578bdb532cd88333569ef3f77042653e1a9f2d9d"]:
{{{
#!CommitTicketReference repository=""
revision="578bdb532cd88333569ef3f77042653e1a9f2d9d"
Added tests and minified javascript missing in
83a3add4bed8d8d49f93b30c817c66908b0a26ba.
Refs #22038.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:6>
Django
Reporter: bpeschier | Owner: bpeschier
Component: contrib.admin | Version: master
Severity: Normal | Resolution: fixed
Keywords: nlsprint14 | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by bpeschier):
* status: assigned => closed
* resolution: => fixed
Comment:
And that commit actually fixed it
--
Ticket URL: <https://code.djangoproject.com/ticket/22038#comment:7>