[Django] #20567: Documenting form widget initial attrs

4 views
Skip to first unread message

Django

unread,
Jun 6, 2013, 6:04:48 AM6/6/13
to django-...@googlegroups.com
#20567: Documenting form widget initial attrs
--------------------------------------+--------------------
Reporter: littlepig | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Documentation | Version: 1.5
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+--------------------
By the accepted answer on this [http://stackoverflow.com/questions/7910353
/django-change-the-dom-id-at-form-field-level stackoverflow question], it
seems it is possible to override the 'id' attribute of a widget without
interfering with django's forms framework.

I think this issue of initial values of attrs should be better documented
on built-in widgets.

--
Ticket URL: <https://code.djangoproject.com/ticket/20567>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jun 6, 2013, 12:06:47 PM6/6/13
to django-...@googlegroups.com
#20567: Documenting form widget initial attrs
--------------------------------------+------------------------------------
Reporter: littlepig | Owner: timo
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.5
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timo):

* status: new => assigned
* needs_better_patch: => 0
* needs_tests: => 0
* owner: nobody => timo
* needs_docs: => 0
* stage: Unreviewed => Accepted


Comment:

I'll work on this. Think it makes sense to also document
`BoundField.id_for_label` as noted in #12856.

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:1>

Django

unread,
Jun 6, 2013, 2:19:39 PM6/6/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget

--------------------------------------+------------------------------------
Reporter: littlepig | Owner: timo
Type: Cleanup/optimization | Status: assigned
Component: Documentation | Version: 1.5

Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by timo):

* cc: timograham@… (added)
* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/1250

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:2>

Django

unread,
Jun 8, 2013, 7:53:25 PM6/8/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------+--------------------------------------
Reporter: littlepig | Owner: timo
Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):

* needs_better_patch: 0 => 1
* component: Documentation => contrib.admin
* needs_tests: 0 => 1
* version: 1.5 => master
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* type: Cleanup/optimization => Uncategorized
* stage: Accepted => Unreviewed


Comment:

1

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:3>

Django

unread,
Jun 8, 2013, 7:53:26 PM6/8/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------+--------------------------------------
Reporter: littlepig | Owner: anonymous

Type: Uncategorized | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):

* needs_better_patch: 0 => 1
* component: Documentation => contrib.admin
* needs_tests: 0 => 1

* owner: timo => anonymous


* version: 1.5 => master
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* type: Cleanup/optimization => Uncategorized
* stage: Accepted => Unreviewed


Comment:

1

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:4>

Django

unread,
Jun 8, 2013, 7:53:26 PM6/8/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------+--------------------------------------
Reporter: littlepig | Owner:
Type: Uncategorized | Status: new

Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: 1 | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 1
Needs tests: 1 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------+--------------------------------------
Changes (by ogpcludi <sample@…>):

* status: assigned => new


* needs_better_patch: 0 => 1
* component: Documentation => contrib.admin
* needs_tests: 0 => 1
* owner: timo =>

* version: 1.5 => master
* keywords: => 1
* needs_docs: 0 => 1
* ui_ux: 0 => 1
* type: Cleanup/optimization => Uncategorized
* stage: Accepted => Unreviewed


Comment:

1

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:5>

Django

unread,
Jun 9, 2013, 6:34:11 AM6/9/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------------+-------------------------------------
Reporter: littlepig | Owner: timo
Type: | Status: assigned
Cleanup/optimization | Version: 1.5
Component: Documentation | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Kamu):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:3>

Django

unread,
Jun 9, 2013, 12:15:39 PM6/9/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------------+-------------------------------------
Reporter: littlepig | Owner: timo
Type: | Status: closed
Cleanup/optimization | Version: 1.5
Component: Documentation | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: assigned => closed
* resolution: => fixed


Comment:

In [changeset:"175a102ddceae2ebd1a4e03916a23adafc35bda5"]:
{{{
#!CommitTicketReference repository=""
revision="175a102ddceae2ebd1a4e03916a23adafc35bda5"
Fixed #20567 - Documented BoundField.id_for_label.

Thanks littlepig for the suggestion.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:4>

Django

unread,
Jun 9, 2013, 12:18:04 PM6/9/13
to django-...@googlegroups.com
#20567: Document BoundField.id_for_label and how to set the 'id' of a widget
-------------------------------------+-------------------------------------
Reporter: littlepig | Owner: timo
Type: | Status: closed
Cleanup/optimization | Version: 1.5
Component: Documentation | Resolution: fixed
Severity: Normal | Triage Stage: Ready for
Keywords: | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"3bd9852401cfbc8a1dfec4082303a5514ee69bf4"]:
{{{
#!CommitTicketReference repository=""
revision="3bd9852401cfbc8a1dfec4082303a5514ee69bf4"
[1.5.x] Fixed #20567 - Documented BoundField.id_for_label.

Thanks littlepig for the suggestion.

Backport of 175a102ddc from master.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/20567#comment:5>

Reply all
Reply to author
Forward
0 new messages