[Django] #22772: django.contrib.formtools test failures on Windows due to failure to delete file that is being used by another process
Django
file that is being used by another process
-----------------------------------+------------------------
Reporter: manfre | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.formtools | Version: 1.7-beta-2
Severity: Release blocker | Keywords: Windows
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
-----------------------------------+------------------------
One of many similar errors with Windows, Python 2.7, Django stable/1.7.x,
and sqlite.
{{{
======================================================================
ERROR: test_form_refresh
(django.contrib.formtools.tests.wizard.wizardtests.tests.CookieWizardTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"C:\projects\django\django\django\contrib\formtools\tests\wizard\wizardtests\tests.py",
line 49, in tearDown
temp_storage.delete(file)
File "C:\projects\django\django\django\core\files\storage.py", line 262,
in delete
os.remove(name)
WindowsError: [Error 32] The process cannot access the file because it is
being used by another process:
u'c:\\users\\manfre\\appdata\\local\\temp\\django_sqv5du\\tmpruqopl\\tests.py'
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22772>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
file that is being used by another process
Reporter: manfre | Owner: nobody
Type: Uncategorized | Status: new
Component: contrib.formtools | Version: 1.7-beta-2
Keywords: Windows | Triage Stage: Unreviewed
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by manfre):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
Bisect:
fa8b4735287c92b03d23823de8a4e1168d1951d9 is the first bad commit
commit fa8b4735287c92b03d23823de8a4e1168d1951d9
Author: Simon Charette <chare...@gmail.com>
Date: Fri Mar 21 03:38:25 2014 -0400
Fixed #22299 -- Cleanup wizard temp files when possible.
Thanks to @erikr for the review.
:040000 040000 de97d643027f86341b993b19cf2b1896112a9ad5
c488ebce1872f6fe8d51ec97e724d30e569c7ed0 M django
:040000 040000 232d71b4aad76a1a62b7e93015ac0863769a04e4
bf1b2199bdd62a95f0666219607ce2a2a8a8a96f M docs
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:1>
Django
file that is being used by another process
Reporter: manfre | Owner: nobody
Type: Bug | Status: new
Component: contrib.formtools | Version: 1.7-beta-2
Severity: Release blocker | Resolution:
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timo):
* type: Uncategorized => Bug
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:2>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: assigned
Component: contrib.formtools | Version: 1.7-beta-2
Severity: Release blocker | Resolution:
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by charettes):
* status: new => assigned
* owner: nobody => charettes
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:3>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Component: contrib.formtools | Version: 1.7-beta-2
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Simon Charette <charette.s@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"e2112edd9ac6a5f1877a62dd1c88d2d1726350de"]:
{{{
#!CommitTicketReference repository=""
revision="e2112edd9ac6a5f1877a62dd1c88d2d1726350de"
Fixed #22772 -- Defer wizard temporary files deletion.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:4>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
While working on my Windows VM I accidently pushed this commit in Django
master instead of my feature branch at charettes/django...
Could you give it a try while it's there? It fixed the "The process cannot
access the file because it is being used by another process" error for me.
I might have to just revert this commit.
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:5>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by manfre):
Tests no longer fail with the provided commit.
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:6>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
Well at this point if another core developer could review
e2112edd9ac6a5f1877a62dd1c88d2d1726350de I would just backport it to 1.7.x
if everything is ok.
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:7>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by Simon Charette <charette.s@…>):
In [changeset:"2b13576c8f48bde808f58621ff26e5b1ab3ed4c1"]:
{{{
#!CommitTicketReference repository=""
revision="2b13576c8f48bde808f58621ff26e5b1ab3ed4c1"
[1.7.x] Fixed #22772 -- Defer wizard temporary files deletion.
Backport of e2112edd9a from master
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:8>
Django
file that is being used by another process
Reporter: manfre | Owner: charettes
Type: Bug | Status: closed
Severity: Release blocker | Resolution: fixed
Keywords: Windows | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by charettes):
Backported to 1.7.x following
[https://github.com/django/django/commit/e2112edd9ac6a5f1877a62dd1c88d2d1726350de#commitcomment-6592575
@timgraham's review].
--
Ticket URL: <https://code.djangoproject.com/ticket/22772#comment:9>