[Django] #25635: URLValidator regex is not allowing '+' character in scheme and also scheme part is optional
Django
part is optional
--------------------------------+------------------------------------------
Reporter: | Owner: nobody
DheerendraRathor |
Type: Bug | Status: new
Component: Core (Other) | Version: 1.8
Severity: Normal | Keywords: urlvalidator, regexvalidator
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------+------------------------------------------
Quoting w3's url-spec
A complete URL consists of a naming scheme specifier followed by a string
whose format is a function of the naming scheme.
and
Within the URL of a object, the first element is the name of the scheme,
separated from the rest of the object by a colon. The rest of the URL
follows the colon in a format depending on the scheme.
So basically scheme should be present in URL syntax. Current scheme regex
is `^(?:[a-z0-9\.\-]*)://` which allows empty schemes.
Also schemes should allow alphanumeric characters with `-`, `.` and `+`
([https://tools.ietf.org/html/rfc1738#section-2.1 rfc1738]).
--
Ticket URL: <https://code.djangoproject.com/ticket/25635>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
part is optional
Reporter: DheerendraRathor | Owner: nobody
Type: Bug | Status: new
Component: Core (Other) | Version: 1.8
Keywords: urlvalidator, | Triage Stage:
regexvalidator | Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0
Comment:
When does a plus sign appear in the scheme in practice? I think schema
validation is handled outside of the regular expression. Could you give an
example of unexpected behavior with actual inputs?
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:1>
Django
part is optional
Reporter: DheerendraRathor | Owner: nobody
Component: Core (Other) | Version: 1.8
Keywords: urlvalidator, | Triage Stage:
regexvalidator | Unreviewed
Has patch: 0 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Comment (by DheerendraRathor):
The very common example is git with ssh i.e. using `git+ssh` in scheme
name. Hg-Git plugin uses this scheme http://hg-git.github.io/. Yeah they
are somewhat rarely used. I guess Phabricator default ssh clone URL is
also git+ssh.
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:2>
Django
part is optional
Reporter: DheerendraRathor | Owner: nobody
Component: Core (Other) | Version: 1.8
Keywords: urlvalidator, | Triage Stage: Accepted
regexvalidator |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 0 => 1
* has_patch: 0 => 1
* stage: Unreviewed => Accepted
Comment:
[https://github.com/django/django/pull/5504 PR]
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:3>
Django
-------------------------------------+-------------------------------------
Reporter: DheerendraRathor | Owner: nobody
Component: Core (Other) | Version: 1.8
Keywords: urlvalidator, | Triage Stage: Ready for
regexvalidator | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by timgraham):
* needs_better_patch: 1 => 0
* stage: Accepted => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:4>
Django
-------------------------------------+-------------------------------------
Reporter: DheerendraRathor | Owner: nobody
Component: Core (Other) | Version: 1.8
Keywords: urlvalidator, | Triage Stage: Ready for
regexvalidator | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"06627ef2caa6854540b50b6f6309c7d12ccfb56a" 06627ef]:
{{{
#!CommitTicketReference repository=""
revision="06627ef2caa6854540b50b6f6309c7d12ccfb56a"
Fixed #25635 -- Made URLValidator allow '+' in scheme.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:5>
Django
-------------------------------------+-------------------------------------
Reporter: DheerendraRathor | Owner: nobody
Type: Bug | Status: closed
Keywords: urlvalidator, | Triage Stage: Ready for
regexvalidator | checkin
Has patch: 1 | Needs documentation: 0
Easy pickings: 0 | UI/UX: 0
Changes (by zborboa-google):
* cc: zborboa@… (added)
--
Ticket URL: <https://code.djangoproject.com/ticket/25635#comment:6>