[django/django] 584bd1: Fixed #18134 -- BoundField.label_tag now includes ...

[GitHub]

Branch: refs/heads/master
Home: https://github.com/django/django
Commit: 584bd14dcfdee9585fec7794d53ce120ea73d0bc
https://github.com/django/django/commit/584bd14dcfdee9585fec7794d53ce120ea73d0bc
Author: Gabe Jackson <gabej...@cxg.ch>
Date: 2013-06-10 (Mon, 10 Jun 2013)

Changed paths:
M django/forms/forms.py
M docs/ref/forms/api.txt
M docs/releases/1.6.txt
M docs/topics/forms/index.txt
M docs/topics/forms/modelforms.txt
M tests/admin_util/tests.py
M tests/forms_tests/tests/test_forms.py
M tests/forms_tests/tests/test_regressions.py

Log Message:
-----------
Fixed #18134 -- BoundField.label_tag now includes the form's label_suffix

There was an inconsistency between how the label_tag for forms were
generated depending on which method was used: as_p, as_ul and as_table
contained code to append the label_suffix where as label_tag called on a
form field directly did NOT append the label_suffix. The code for
appending the label_suffix has been moved in to the label_tag code of
the field and the HTML generation code for as_p, as_ul and as_table now
calls this code as well.

This is a backwards incompatible change because users who have added the
label_suffix manually in their templates may now get double label_suffix
characters in their forms.