[Django] #29275: Emit "(actual errors: none)" instead of "(actual errors: )"
Django
------------------------------------------------+------------------------
Reporter: Chris Lamb | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: Testing framework | Version: 2.0
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Needs documentation: 0 | Needs tests: 0
Patch needs improvement: 0 | Easy pickings: 0
UI/UX: 0 |
------------------------------------------------+------------------------
The suffix in, for
{{{
AssertionError: False is not true : The form 'form' in context 0 does not
contain the non-field error 'Please enter a correct email and password.
Note that both fields may be case-sensitive.' (actual errors: )
}}}
is kinda weird. We should print "none" instead, otherwise it looks like
there is an error in the error.
--
Ticket URL: <https://code.djangoproject.com/ticket/29275>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
assertFormError
-------------------------------------+-------------------------------------
Reporter: Chris Lamb | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: 2.0
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Chris Lamb):
* has_patch: 0 => 1
Old description:
> The suffix in, for
>
> {{{
> AssertionError: False is not true : The form 'form' in context 0 does not
> contain the non-field error 'Please enter a correct email and password.
> Note that both fields may be case-sensitive.' (actual errors: )
> }}}
>
> is kinda weird. We should print "none" instead, otherwise it looks like
> there is an error in the error.
New description:
The suffix in the error output of assertFormError (eg.)
{{{
AssertionError: False is not true : The form 'form' in context 0 does not
contain the non-field error 'Please enter a correct email and password.
Note that both fields may be case-sensitive.' (actual errors: )
}}}
is kinda weird. We should print "none" instead, otherwise it looks like
there is an error in the error.
--
Comment:
https://github.com/django/django/pull/9837
--
Ticket URL: <https://code.djangoproject.com/ticket/29275#comment:1>
Django
assertFormError
-------------------------------------+-------------------------------------
Reporter: Chris Lamb | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Claude Paroz):
* version: 2.0 => master
* stage: Unreviewed => Ready for checkin
--
Ticket URL: <https://code.djangoproject.com/ticket/29275#comment:2>
Django
assertFormError
-------------------------------------+-------------------------------------
Reporter: Chris Lamb | Owner: nobody
Cleanup/optimization |
Component: Testing framework | Version: master
Keywords: | Triage Stage: Ready for
| checkin
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: new => closed
* resolution: => fixed
Comment:
In [changeset:"84ad721bd9fe7317530bde2b90ba002490717c27" 84ad721]:
{{{
#!CommitTicketReference repository=""
revision="84ad721bd9fe7317530bde2b90ba002490717c27"
Fixed #29275 -- Made assertFormError() output "(actual errors: none)"
instead of "(actual errors: )".
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/29275#comment:3>