[Django] #26343: user_login_failed not fired on PermissionDenied
Django
------------------------------+--------------------
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
------------------------------+--------------------
If an authentication backend raises `PermissionDenied`, the
`authenticate()` function will short-circuit, and fail to fire the
`user_login_failed` signal.
--
Ticket URL: <https://code.djangoproject.com/ticket/26343>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
Django
Reporter: knbk | Owner: nobody
Type: Bug | Status: new
Component: contrib.auth | Version: master
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* needs_docs: => 0
* needs_better_patch: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:1>
Django
Reporter: knbk | Owner: ieatkittens
Type: Bug | Status: assigned
Component: contrib.auth | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by ieatkittens):
* status: new => assigned
* owner: nobody => ieatkittens
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:2>
Django
Reporter: knbk | Owner: ieatkittens
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Comment (by ieatkittens):
Work is available at
https://github.com/ieatkittens/django/tree/ticket_26343. Docs build fine
and tests pass under Postgresql. First time contributing so please let me
know if I am missing anything!
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:3>
Django
Reporter: knbk | Owner: ieatkittens
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Needs tests: 1 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
Changes (by timgraham):
* has_patch: 0 => 1
* needs_tests: 0 => 1
Comment:
When adding a link to the pull request, please check "Has patch". Please
uncheck "Needs tests" when you update your pull request with one.
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:4>
Django
Reporter: knbk | Owner: ieatkittens
Type: Bug | Status: assigned
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by ieatkittens):
* needs_tests: 1 => 0
Comment:
Regression test added!
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:5>
Django
Reporter: knbk | Owner: ieatkittens
Component: contrib.auth | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Easy pickings: 1 | UI/UX: 0
Changes (by Tim Graham <timograham@…>):
* status: assigned => closed
* resolution: => fixed
Comment:
In [changeset:"ab8af342b1d5dbe40502f1adfe8c7a6b746c8004" ab8af342]:
{{{
#!CommitTicketReference repository=""
revision="ab8af342b1d5dbe40502f1adfe8c7a6b746c8004"
Fixed #26343 -- Sent user_login_failed signal if an auth backend raises
PermissionDenied.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/26343#comment:6>