[Django] #23005: Improve zh-* language code handling

15 views
Skip to first unread message

Django

unread,
Jul 11, 2014, 12:06:24 PM7/11/14
to django-...@googlegroups.com
#23005: Improve zh-* language code handling
--------------------------------------+-------------------------------
Reporter: caxekis@… | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Keywords: i18n, chinese, zh
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+-------------------------------
As per #18419, zh-cn and zh-tw are deprecated and one of the reason was
that "...Traditional Chinese is not used only by Taiwan (tw) but also Honk
Kong (hk), and Simplified Chinese is not only used in China (cn) but also
Singapore (sg) and Malaysia..." . However pull #1868
https://github.com/django/django/pull/1868 did not specify fallback for
those language variant.

I would say we should follow Mediawiki's configuration for chinese
language variants fallback (see
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/e016f6aa9386f515398d07d25419650c1fb74bf6/languages%2Fclasses%2FLanguageZh.php#L104
line 104 ).
* zh-cn, zh-sg and zh-my fallback to zh-hans
* zh-hk, zh-mo and zh-tw fallback to zh-hant

--
Ticket URL: <https://code.djangoproject.com/ticket/23005>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Jul 11, 2014, 2:22:34 PM7/11/14
to django-...@googlegroups.com
#23005: Improve zh-* language code handling
--------------------------------------+------------------------------------

Reporter: caxekis@… | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: i18n, chinese, zh | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):

* needs_better_patch: => 0
* needs_docs: => 0
* needs_tests: => 0
* stage: Unreviewed => Accepted


--
Ticket URL: <https://code.djangoproject.com/ticket/23005#comment:1>

Django

unread,
Jul 11, 2014, 3:08:13 PM7/11/14
to django-...@googlegroups.com
#23005: Improve zh-* language code handling
--------------------------------------+------------------------------------

Reporter: caxekis@… | Owner: nobody
Type: Bug | Status: new
Component: Internationalization | Version: master
Severity: Normal | Resolution:
Keywords: i18n, chinese, zh | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by claudep):

* has_patch: 0 => 1


Comment:

https://github.com/django/django/pull/2905

--
Ticket URL: <https://code.djangoproject.com/ticket/23005#comment:2>

Django

unread,
Jul 14, 2014, 9:48:03 AM7/14/14
to django-...@googlegroups.com
#23005: Improve zh-* language code handling
-------------------------------------+-------------------------------------

Reporter: caxekis@… | Owner: nobody
Type: Bug | Status: new
Component: | Version: master
Internationalization | Resolution:
Severity: Normal | Triage Stage: Ready for
Keywords: i18n, chinese, zh | checkin

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by timo):

* stage: Accepted => Ready for checkin


--
Ticket URL: <https://code.djangoproject.com/ticket/23005#comment:3>

Django

unread,
Jul 14, 2014, 3:00:40 PM7/14/14
to django-...@googlegroups.com
#23005: Improve zh-* language code handling
-------------------------------------+-------------------------------------
Reporter: caxekis@… | Owner: nobody
Type: Bug | Status: closed
Component: | Version: master
Internationalization | Resolution: fixed

Severity: Normal | Triage Stage: Ready for
Keywords: i18n, chinese, zh | checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Claude Paroz <claude@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"5dcdbe95c749d36072f527e120a8cb463199ae0d"]:
{{{
#!CommitTicketReference repository=""
revision="5dcdbe95c749d36072f527e120a8cb463199ae0d"
Fixed #23005 -- Allowed specifying special fallback languages

This fixes the Chinese language issues described in #23005 but
also provides for other fallback exceptions by updating the
LANG_INFO structure.
Thanks caxekis at gmail.com for the report and Tim Graham for the
review.
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/23005#comment:4>

Reply all
Reply to author
Forward
0 new messages