[Django] #26477: Docs: Example about bookmarks mentions books

12 views
Skip to first unread message

Django

unread,
Apr 7, 2016, 12:59:25 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------
Reporter: decibyte | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------
In the docs about the contenttypes framework, there's an example of using
`related_query_name` for `GenericRelation`. In the second part of the code
example, the comment says:

{{{
Get all tags belonging to books containing `django` in the url
}}}

But the example is about bookmarks, not books.

https://github.com/django/django/blob/ecb59cc6579402b68ddfd4499bf30edacf5963be/docs/ref/contrib/contenttypes.txt#L386-L396

I have attached a patch for this. I'd be happy to provide it via a pull
request on GitHub, if that is a better of contributing a tiny fix like
this.

--
Ticket URL: <https://code.djangoproject.com/ticket/26477>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,
Apr 7, 2016, 1:00:07 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
---------------------------+----------------------------

Reporter: decibyte | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:

Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Easy pickings: 1
UI/UX: 0 |
---------------------------+----------------------------
Changes (by decibyte):

* Attachment "contenttypes-docs-fix.patch" added.

A patch to replace "books" with "bookmarks"

Django

unread,
Apr 7, 2016, 1:02:47 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------------------------

Reporter: decibyte | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by decibyte):

* needs_better_patch: => 0
* needs_tests: => 0
* needs_docs: => 0


--
Ticket URL: <https://code.djangoproject.com/ticket/26477#comment:1>

Django

unread,
Apr 7, 2016, 1:03:29 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------------------------

Reporter: decibyte | Owner: nobody
Type: Bug | Status: new
Component: Documentation | Version: master
Severity: Normal | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by decibyte):

* has_patch: 0 => 1


--
Ticket URL: <https://code.djangoproject.com/ticket/26477#comment:2>

Django

unread,
Apr 7, 2016, 1:54:10 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------------------------
Reporter: decibyte | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"4bb3ddbcc674601743c63311d7efbf0e1fd19742" 4bb3ddbc]:
{{{
#!CommitTicketReference repository=""
revision="4bb3ddbcc674601743c63311d7efbf0e1fd19742"
Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26477#comment:4>

Django

unread,
Apr 7, 2016, 1:54:10 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------------------------
Reporter: decibyte | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------
Changes (by Tim Graham <timograham@…>):

* status: new => closed
* resolution: => fixed


Comment:

In [changeset:"92d77f31606e5fb2b1a5d0963fed0433d766a920" 92d77f31]:
{{{
#!CommitTicketReference repository=""
revision="92d77f31606e5fb2b1a5d0963fed0433d766a920"
[1.9.x] Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt

Backport of 4bb3ddbcc674601743c63311d7efbf0e1fd19742 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26477#comment:3>

Django

unread,
Apr 7, 2016, 1:54:13 PM4/7/16
to django-...@googlegroups.com
#26477: Docs: Example about bookmarks mentions books
-------------------------------+--------------------------------------
Reporter: decibyte | Owner: nobody
Type: Bug | Status: closed
Component: Documentation | Version: master
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Unreviewed

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 0
-------------------------------+--------------------------------------

Comment (by Tim Graham <timograham@…>):

In [changeset:"7c67508a801ba2435c7d45a6982a9beb2203cf73" 7c67508a]:
{{{
#!CommitTicketReference repository=""
revision="7c67508a801ba2435c7d45a6982a9beb2203cf73"
[1.8.x] Fixed #26477 -- Fixed typo in docs/ref/contrib/contenttypes.txt

Backport of 4bb3ddbcc674601743c63311d7efbf0e1fd19742 from master
}}}

--
Ticket URL: <https://code.djangoproject.com/ticket/26477#comment:5>

Reply all
Reply to author
Forward
0 new messages