Re: [Django] #35673: ExceptionReporter.get_traceback_data() does not handle when request.GET data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
---------------------------------+------------------------------------
Reporter: Pēteris Caune | Owner: (none)
Type: Bug | Status: new
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+------------------------------------
Comment (by Mohammad Salehi):

Hello, I would like to work on this issue if you’re okay with it?
--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:2>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS

-------------------------------------+-------------------------------------
Reporter: Pēteris Caune | Owner: Mohammad
| Salehi
Type: Bug | Status: assigned

Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

-------------------------------------+-------------------------------------
Changes (by Mohammad Salehi):

* owner: (none) => Mohammad Salehi
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:3>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
-------------------------------------+-------------------------------------
Reporter: Pēteris Caune | Owner: Mohammad
| Salehi
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------

Comment (by Mohammad Salehi):

Hello,

I have worked on this issue and tested some possible solutions. These are
the results:

1_ Adding a flag in `QueryDict` class:
This does not work because `QueryDict` is recreated with each request so
the flag state is not kept requests.

2_ Changing return value of `GET` and `POST` methods in `WSGIRequest`
class:
Changing how `GET` and `POST` methods return values will only stop the
`TooManyFieldsSent` error from showing. This will make `GET` and `POST`
methods not work at all. Request processing will not work correctly and
important data will be lost. This approach only hides the error message
and does not fix the real problem with handling data.

3_ Removing all `GET` data:
If we set `request.GET` to an empt dict in foo method, it shows the error
and the problem got fixed but it doesn't make sense to alter GET data.
--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:4>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
-------------------------------------+-------------------------------------
Reporter: Pēteris Caune | Owner: Mohammad
| Salehi
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Mohammad Salehi):

We are encountering a very specific and complex error in the lower layers
of the framework. Currently, we use `request.GET` to retrieve GET
parameters. However, if `request.GET` encounters an error for any reason,
how can the higher layers of the framework access these values and display
the necessary information on the error page?

which this issue's scenario has exactly the very same problem.

What is your opinion on this?
--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:5>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS

---------------------------------+----------------------------------------
Reporter: Pēteris Caune | Owner: Ahmed Nassar

Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0

---------------------------------+----------------------------------------
Changes (by Ahmed Nassar):

* owner: Mohammad Salehi => Ahmed Nassar

Comment:

I'll be happy to work on this ticket and submit my PR soon.
--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:6>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
---------------------------------+----------------------------------------
Reporter: Pēteris Caune | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted

Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------
Changes (by Ahmed Nassar):

* has_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:7>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
---------------------------------+----------------------------------------
Reporter: Pēteris Caune | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:8>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
---------------------------------+----------------------------------------
Reporter: Pēteris Caune | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------

Changes (by Ahmed Nassar):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:9>

[Django]

#35673: ExceptionReporter.get_traceback_data() does not handle when request.GET
data exceeds DATA_UPLOAD_MAX_NUMBER_FIELDS
---------------------------------+----------------------------------------
Reporter: Pēteris Caune | Owner: Ahmed Nassar
Type: Bug | Status: assigned
Component: Error reporting | Version: 5.1
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 0 | UI/UX: 0
---------------------------------+----------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/35673#comment:10>