Re: [Django] #36829: ClearableFileInput.use_fieldset became True in Django 6.0

[Django]

#36829: ClearableFileInput.use_fieldset became True in Django 6.0
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron
Type: Bug | Status: assigned
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: fieldset, legend | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* stage: Accepted => Ready for checkin

--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:13>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

[Django]

#36829: ClearableFileInput.use_fieldset became True in Django 6.0
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron

Type: Bug | Status: closed
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution: fixed

Keywords: fieldset, legend | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls <jacobtylerwalls@…>):

* resolution: => fixed
* status: assigned => closed

Comment:

In [changeset:"79ab0993d0f2253e10ea638bcefc98ec2d890a47" 79ab0993]:
{{{#!CommitTicketReference repository=""
revision="79ab0993d0f2253e10ea638bcefc98ec2d890a47"
Fixed #36829 -- Reverted value of ClearableFileInput.use_fieldset to True.

There was unresolved discussion regarding whether to set
ClearableFileInput.use_fieldset to True or False when use_fieldset was
introduced in Django 4.1, since the clear checkbox appears only
sometimes. Although using <fieldset> is likely desirable, since the
primary motivation in #35892 was just to improve markup in the admin,
and a deprecation path was not provided for general form usage, future
work is deferred to #36828.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

Thanks Tim Graham, Antoliny, and David Smith for triage.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:14>

[Django]

#36829: ClearableFileInput.use_fieldset became True in Django 6.0
-------------------------------------+-------------------------------------
Reporter: Johannes Maron | Owner: Johannes
| Maron
Type: Bug | Status: closed
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution: fixed
Keywords: fieldset, legend | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Jacob Walls <jacobtylerwalls@…>):

In [changeset:"b7b5465b1c026dda7de646fca15ca1e97886d021" b7b5465]:
{{{#!CommitTicketReference repository=""
revision="b7b5465b1c026dda7de646fca15ca1e97886d021"
[6.0.x] Fixed #36829 -- Reverted value of ClearableFileInput.use_fieldset

to True.

There was unresolved discussion regarding whether to set
ClearableFileInput.use_fieldset to True or False when use_fieldset was
introduced in Django 4.1, since the clear checkbox appears only
sometimes. Although using <fieldset> is likely desirable, since the
primary motivation in #35892 was just to improve markup in the admin,
and a deprecation path was not provided for general form usage, future
work is deferred to #36828.

Regression in 4187da258fe212d494cb578a0bc2b52c4979ab95.

Thanks Tim Graham, Antoliny, and David Smith for triage.
}}}
--

Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:15>