Re: [Django] #13883: SelectBox.js with grouping (optgroup elements)

Django

unread,

May 5, 2011, 2:40:43 PM5/5/11

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: nobody
Type: Bug | Status: new
Milestone: 1.3 | Component: contrib.admin
Version: 1.2 | Severity: Normal
Resolution: | Keywords: admin, SelectBox,
Triage Stage: Accepted | optgroup, sprintdec2010
Needs documentation: 0 | Has patch: 1
Patch needs improvement: 1 | Needs tests: 0
| Easy pickings: 0
-------------------------------------+-------------------------------------
Changes (by patchhammer):

* needs_better_patch: 0 => 1
* easy: => 0

Comment:

options.py.diff fails to apply cleanly on to trunk

--
Ticket URL: <http://code.djangoproject.com/ticket/13883#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

Django

unread,

Nov 13, 2014, 7:32:51 AM11/13/14

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: nobody
Type: Bug | Status: new

Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by rynomster):

Did this change ever make it to trunk?
I can't seem to find it.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:10>

Django

unread,

Nov 13, 2014, 7:38:59 AM11/13/14

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin | Version: 1.2
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 | Needs documentation: 0
Has patch: 1 | Patch needs improvement: 1
Needs tests: 0 | UI/UX: 1
Easy pickings: 0 |
-------------------------------------+-------------------------------------

Comment (by timgraham):

No, the ticket is still open. It doesn't appear we have a tested patch.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:11>

Django

unread,

Dec 20, 2018, 5:29:19 AM12/20/18

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: nobody

Type: New feature | Status: new
Component: contrib.admin | Version: master

Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |

Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Narbonne):

* cc: Narbonne (added)
* version: 1.2 => master
* type: Bug => New feature

Comment:

subscribing too. a bit sad to see the feature I was looking for in an
abandoned old ticket.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:12>

Django

unread,

Dec 20, 2018, 7:05:07 AM12/20/18

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: nobody

Type: Bug | Status: new

Changes (by Simon Charette):

* type: New feature => Bug

Comment:

Hello Narbonne,

I get your feeling about discovering a still unsolved long standing issue.
Most of Django contributors are volunteers though and issues only get
fixed if someone commits to spend a part of their limited amount of time
to submitting a patch and testing it. Given this issue hasn't received a
lot of attention in the past years I assume it wasn't critical enough for
someone to some of their time to it.

If it is to you I'd encourage you to go through the
[https://docs.djangoproject.com/en/2.1/internals/contributing/
contributing guide] and try to revive the previous patch. From a quick
look it seems like adding `optgroup` support to `SelectBox.js` and adding
a `group_by` option to `ModelChoiceField` à la #27331.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:13>

Django

unread,

Apr 17, 2020, 2:19:07 AM4/17/20

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------

Reporter: SardarNL | Owner: Jignesh
| Kotadiya
Type: Bug | Status: assigned

Changes (by Jignesh Kotadiya):

* owner: nobody => Jignesh Kotadiya
* status: new => assigned

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:14>

Django

unread,

Apr 17, 2020, 2:31:33 AM4/17/20

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Jignesh
| Kotadiya
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1

-------------------------------------+-------------------------------------
Changes (by Jignesh Kotadiya):

* cc: Jignesh Kotadiya (added)
* easy: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:15>

Django

unread,

Apr 17, 2020, 4:31:15 AM4/17/20

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Jignesh
| Kotadiya
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Jignesh Kotadiya):

[https://github.com/django/django/pull/12737]

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:16>

Django

unread,

Dec 9, 2020, 9:21:04 PM12/9/20

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------

Reporter: SardarNL | Owner: Abhiraj
| Chatterjee

Changes (by Abhiraj Chatterjee):

* owner: Nishant Sagar => Abhiraj Chatterjee

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:18>

Django

unread,

Jan 20, 2021, 9:16:41 AM1/20/21

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Abhiraj
| Chatterjee
Type: Bug | Status: assigned
Component: contrib.admin | Version: master
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Marius Räsener):

Hello everybody,

I'm trying to contribute to Django with this "easy picking" issue. The PR
on Github was closed by Jignesh Kotadiya and currently the PR says
`jigneshkotadiya000 wants to merge 0 commits into 'django:master' from
'unknown repository'` - so I'm already stuck I guess.
Is this still issue still open? If yes, should I give it a try?

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:19>

Django

unread,

Jul 19, 2021, 8:58:54 AM7/19/21

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Abhiraj
| Chatterjee
Type: Bug | Status: assigned

Component: contrib.admin | Version: dev

Comment (by ᴙɘɘᴙgYmɘᴙɘj):

Here's a [minimal repro](https://github.com/reergymerej/ticket_13883) for
anyone who is interested.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:20>

Django

unread,

Oct 12, 2021, 3:37:21 AM10/12/21

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------

Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new

Changes (by Mariusz Felisiak):

* owner: Abhiraj Chatterjee => (none)
* status: assigned => new

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:21>

Django

unread,

Mar 24, 2022, 6:15:22 PM3/24/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Michael McLarnon):

* Attachment "13883-fix.patch" added.

Patch to retain option groups, and test

--
Ticket URL: <https://code.djangoproject.com/ticket/13883>

Django

unread,

Mar 25, 2022, 1:12:22 AM3/25/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Thanks, please send [https://github.com/django/django/pulls PR via
GitHub].

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:22>

Django

unread,

Mar 25, 2022, 11:02:54 AM3/25/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Old description:

> Current implementation ignores optgroup elements in selects. Here is an
> example of SelectBox.js which takes optgroups in account, but uses jQuery
> (already used by django admin anyway).
> The script is not perfectly written. I can rewrite this to meet django's
> coding/quality standards if needed.

New description:

--

Comment (by Narbonne):

I don't see an update of the filter method. I suppose search should also
search in the optgroup name (a bit like sort before token search).
I update your patch line 45 in filter:
{{{
const node_text = (node.group && node.group.toLowerCase() || '') +
node.text.toLowerCase();
}}}

Also, maybe it could make sense to move optgroup as a block.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:23>

Django

unread,

Apr 7, 2022, 6:41:43 PM4/7/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Michael McLarnon):

Created PR: https://github.com/django/django/pull/15568

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:24>

Django

unread,

Apr 8, 2022, 6:05:01 PM4/8/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Michael McLarnon):

* cc: Michael McLarnon (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:25>

Django

unread,

Apr 12, 2022, 2:39:48 AM4/12/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------

Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* owner: (none) => Michael McLarnon
* needs_better_patch: 1 => 0

* status: new => assigned

Comment:

[https://github.com/django/django/pull/15568 PR]

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:26>

Django

unread,

Apr 28, 2022, 2:39:56 AM4/28/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1
* needs_tests: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:27>

Django

unread,

Dec 10, 2022, 12:55:30 PM12/10/22

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0

Needs tests: 1 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:28>

Django

unread,

Jun 14, 2023, 11:42:23 AM6/14/23

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Natalia Bidart):

* needs_tests: 1 => 0

Comment:

The PR author reported that the PR is ready for re-review, so I'm clearing
the flags.

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:29>

Django

unread,

Jun 15, 2023, 8:22:37 AM6/15/23

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Mariusz Felisiak):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:30>

Django

unread,

Jul 29, 2023, 6:34:16 AM7/29/23

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by rzrwolf):

13 years to fix the issue...

What is current status? Any beta that can be used, please?

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:31>

Django

unread,

Jul 29, 2023, 9:39:46 AM7/29/23

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Mariusz Felisiak):

Replying to [comment:31 rzrwolf]:

> 13 years to fix the issue...
>
> What is current status? Any beta that can be used, please?

This is an open-source, these kind of comments are unhelpful. Feel-free to
prepare a patch, or test [https://github.com/django/django/pull/15568 PR].

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:32>

Django

unread,

Sep 18, 2024, 5:48:02 PM9/18/24

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Aditya Chaudhary):

Is this still required ?
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:33>

Django

unread,

Nov 7, 2024, 2:33:37 AM11/7/24

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Michael
| McLarnon
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Ülgen Sarıkavak):

* cc: Ülgen Sarıkavak (added)

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:34>

Django

unread,

Dec 13, 2024, 9:10:50 PM12/13/24

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner:

| seanhelvey

Changes (by seanhelvey):

* owner: Michael McLarnon => seanhelvey

Comment:

Created PR: https://github.com/django/django/pull/18934.
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:35>

Django

unread,

Jan 4, 2025, 11:11:09 AMJan 4

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------

Reporter: SardarNL | Owner: Sean
| Helvey

Comment (by Sean Helvey):

Hi! This is ready for review.
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:36>

Django

unread,

Jan 4, 2025, 12:22:46 PMJan 4

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

Comment:

Hi Sean, when you're ready for a review please uncheck "Patch needs
improvement." Cheers.
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:37>

Django

unread,

Jan 8, 2025, 8:50:35 AMJan 8

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:38>

Django

unread,

Jan 20, 2025, 2:15:02 PMJan 20

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sean Helvey):

* needs_better_patch: 1 => 0

Comment:

Tests are passing now. Feedback is welcome. Thank you!
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:39>

Django

unread,

Apr 17, 2025, 7:30:07 AMApr 17

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Sarah Boyce):

* needs_better_patch: 0 => 1

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:40>

Django

unread,

Oct 11, 2025, 1:29:56 PMOct 11

to django-...@googlegroups.com

#13883: SelectBox.js with grouping (optgroup elements)
-------------------------------------+-------------------------------------
Reporter: SardarNL | Owner: Sean
| Helvey
Type: Bug | Status: assigned
Component: contrib.admin | Version: dev
Severity: Normal | Resolution:
Keywords: admin, SelectBox, | Triage Stage: Accepted
optgroup, sprintdec2010 |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Comment (by Sean Helvey):

Surprised nobody has used the vulture method to pick this one up! I am
going to review feedback from Sarah and continue working on it now.
Thanks, everyone :)
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:41>

Django

unread,

Nov 10, 2025, 4:20:07 PM (2 days ago) Nov 10

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------

Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

Comment:

Will need a rebase after #36053 lands, but otherwise this should be ready
for a substantive review.
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:42>

Django

unread,

Nov 11, 2025, 4:32:14 PM (14 hours ago) Nov 11

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 1

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 0 => 1

Comment:

Needs a rebase
--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:43>

Django

unread,

Nov 11, 2025, 8:53:33 PM (10 hours ago) Nov 11

to django-...@googlegroups.com

Needs tests: 0 | Patch needs improvement: 0

Easy pickings: 1 | UI/UX: 1
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

* needs_better_patch: 1 => 0

--
Ticket URL: <https://code.djangoproject.com/ticket/13883#comment:44>

Reply all

Reply to author

Forward